919858 - [LockScreen] Enhance the UI experiments when unlocking the phone with one hande

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

It's will be difficult to unlock the phone if the user hold it with one hand on some device, especially when the user's thumb can only hardly to reach the end of the sliding track.

I'll try to make some adjustments to solve this issue, and put some videos here to show the difference.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please only nominate blocking if this causes functional issue on shipping device. Thank you!

However, mark as non-blocking doesn't prevent you to keep working on it.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

I've set the dependency on Bug 919850 because when the handle slides automatically to the end, it would be better if the unlocking only happens when user's finger released. I think the Bug 919850 can be fixed ASAP, and thus this almost finished bug can base on it.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

I've finished this bug, but it needs UX's opinion on the automatically pulling behavior, especially the pulling time (current is 0.5sec) and the triggering position.

I'll take a video for Patrick's reference later.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: 0.5sec auto pull; unlock only when finger release

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

The video had been attached. As you can see, the handle would trigger the auto-pulling when it came to the half of the icon, and pulled 0.5sec to the end. However it won't unlock until user's finger got released.

Comment 6

[Patryk Adamczyk [:patryk] UX]

Looks good. 

Please make sure that the blue underlay stays within the white frame, I couldn't see in the video if it does. So just make sure. Thanks!

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

(In reply to Patryk Adamczyk [:patryk] UX from comment #6)
> Looks good. 
> 
> Please make sure that the blue underlay stays within the white frame, I
> couldn't see in the video if it does. So just make sure. Thanks!

It'll be solved at Bug 921335. Thanks for your opinion, and now I can close this bug after reviewing.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Solve it by adding a reusable `slideTo` function, and set the auto-pulling mechanism.

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/a95b2eb7a1f9d3ce68ebd98b176bb4a11ce99140

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 a95b2eb7a1f9d3ce68ebd98b176bb4a11ce99140
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 12

[Greg Weng [:snowmantw][:gweng][:λ]]

Hello John,

I've leave the related ni in Bug 919854. The conflicts problem should be solved now.

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

Greg, please make sure that you set flags for branch landings when you do them

v1.2: https://github.com/snowmantw/gaia/commit/29be9b6abe0ed4718b42db3f2f61f4ca7df91f29

Comment 14

[sarsenyev]

Verified it's fixed on Leo 1.2 COM RIL
A user can easily unlock the device with one arm,slide bar is enchanced to open it and stays in the white bar

Device: Biri 1.2 COM RIL
BuildID: 20131108004004
Gaia: 4cf40fb30c7b8380ea83ed0d4efe043b8b81737f
Gecko: a886c641a306
Version: 26.0
Firmware Version: US_20131104