Closed
Bug 91990
Opened 25 years ago
Closed 24 years ago
Carbonized build defaults to Classic theme
Categories
(SeaMonkey :: Build Config, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: scalkins, Assigned: jj.enser)
References
Details
(Whiteboard: [PDT+][Fixed on branch])
Attachments
(1 file)
I only see this on Mac OSX
2001-07-21-05 0.9.2 Branch (10.x build)
Steps to repro:
1)Launch Netscape 6.1 with a new profile
2)When browser appears note the theme.
Actual result:
Note the theme is classic.
Default theme should be New Modern, like the other platforms.
See related bugscape bug http://bugscape.netscape.com/show_bug.cgi?id=7865
in commercial release only.
cc: sdagley and pinkerton.
Should the default be the same as the other commercial releases on Mac?
Comment 3•25 years ago
|
||
we should do the same as all the other platforms.
Erm, not sure I agree. As I understand it, the rationale of Classic is to
provide a user experience as similar as possible to that of Navigator 4.x on the
user's native platform, with minor updates if necessary.
Mac OS X has no implementation of Navigator 4.x. Thus, the notion of Classic
under Fizzilla is nothing more than that of Mac OS 9 and earlier.
I submit that an exception to this logic be made, that if no native build of
Navigator 4.x exists on the platform in question and no Classic build exists
that even approximates the native UI of that platform, then Modern becomes the
default theme.
Comment 5•25 years ago
|
||
You know, I always wondered why release builds were defaulting to Classic on my
Mac. I don't think, and I hope nobody else does, we really want the Mac OS X
builds to be defaulting to Classic. The modern theme is much more acceptable to
people on OS X than Classic, so much so that folks have even told me they don't
miss having an Aqua theme.
Comment 6•25 years ago
|
||
not a themes issue, this needs to be resolved by somebody in installer (I think)
Assignee: hewitt → ssu
Component: Themes → Installer
QA Contact: pmac → gemal
Comment 7•25 years ago
|
||
There is no installer for the macosx version. This is the result of the Mozilla
build process which creates an installed-chrome.txt file that selects Classic as
the default. If we want macosx to behave differently someone will have to
hand-edit the file for the Netscape build, or write a script which removes the
classic skin select statement and replaces it with a modern skin select entry.
Bouncing to the "Build component", but assigning to beard to find the owner of
macosx build issues.
Assignee: ssu → beard
Component: Installer → Build Config
QA Contact: gemal → scalkins
Comment 8•25 years ago
|
||
osx issues aside, don't we want the default to be modern on mozilla for macos9 as
well? i mean, we only screamed bloody murder about classic being the default
because blue was so bad. now that modern is getting such good reviews, can we
change this for moz as well?
Additional note, this default "classic theme" has modern elements in it.
If you change your view to "Classic" and restart, the proper classic theme then
shows.
This bug makes IM look pretty sloppy.
Keywords: nsbranch
| Reporter | ||
Comment 10•25 years ago
|
||
IM has an enterprise+ bug depending on this being fixed.
Either with cleaning up the default classic theme, or changing default theme to
modern.
http://bugscape/show_bug.cgi?id=8655
Comment 11•25 years ago
|
||
i think the default should be modern. the classic decision was made a long time
ago when modern wasn't exactly the prettiest girl at the dance. there's no reason
to stick to it now.
Comment 12•25 years ago
|
||
I believe this is causing various ui problems for commercial. nominating
nsenterprise, as this blocks nsenterprise+ bugs in bugscape.
Keywords: nsenterprise
Comment 13•25 years ago
|
||
JJ: Patrick says you're best suited for.
If not please find a new owner ASAP, I'm hoping to get this bug marked
nsenterprise+ soon.
Assignee: beard → jj
Comment 14•25 years ago
|
||
Added nsenterprise+, P1,blocker, m0.9.5, since this bug is blocking a couple of
other nsenterprise+ bugs.
jj@netscape.com: are you working on this bug right now?
Severity: normal → blocker
Keywords: nsenterprise → nsenterprise+
Priority: -- → P1
Target Milestone: --- → mozilla0.9.5
| Assignee | ||
Comment 15•25 years ago
|
||
Accepting bug.
Switching default skin from Classic to Modern requires a simple change in the
Mac build script.
However, doing so will affect both Mozilla AND Netscape products, on both
classic (mac OS 8/9) and carbon (OS X) builds.
We need to make sure this is ok for the mozilla community as well.
I'll work on it and submit a patch after mozilla 0.9.4 is out (since this is
targeted to 0.9.5)
Status: NEW → ASSIGNED
Comment 16•25 years ago
|
||
jj: could you attach the patch so I can test my bugscape bugs with it?
| Assignee | ||
Comment 17•25 years ago
|
||
I've asked here as well as in bugscape bug #8840 for advice as to what the right
approach is.
The patch will depend on if both Mozilla's and Netscape's default theme can be
switched to Modern.
Comment 18•25 years ago
|
||
nsbranch+ since it's already nsenterprise+ to get it off the untriaged radar.
Comment 19•25 years ago
|
||
Greetings everyone:
JJ already has two solutions for this bug. He needs your vote to decide which
solution to implement.
Please take a minute or two to answer jj's questions in this bug.
This bug is blocking at least 3 P1 bugs in IM. We HAD to fix it.
THANKS for your answer in anticipation.
Comment 20•25 years ago
|
||
we can do this fine on win32 and linux. Why can't we do something similar for
Mac? Mozilla builds should default to Classic and Netscape builds to Modern.
Comment 21•25 years ago
|
||
apparently mozilla defaults to classic, so if we can we'd like to see a solution
where Mozilla continues to default to classic, and Netscape defaults to Modern.
I've tested the following change (emailed to me from jj) and it works great, but
a better solution would be for the commercial build tools to change that on the
fly, if that also fixes the problems.
< SetDefaultSkin("classic/1.0");
---
> SetDefaultSkin("modern/1.0");
from IRC:
<jelwell> Asa: so if there isn't a simpler fix, mozilla would not get mad if
they changed the default theme for MacOS on the branch?
<Asa> jelwell: no problem at all.
<jelwell> cool.
<Asa> jelwell: but it would be nice to have a fix. the trunk suffers from this
problem as well.
| Assignee | ||
Comment 22•25 years ago
|
||
ok, so we have more than 2 options now:
1. change the command SetDefaultSkin in the *mozilla* build script on the branch
to use Modern. Now that mozilla 0.9.4 is out (or almost), this will only
affect the next Netscape release. That's a satisfactory short term solution,
IMHO, but as Asa mentioned, this doesn't solve the trunk.
2. Leave SetDefaultSkin("Classic/1.0") untouched in mozilla and add a new call
to SetDefaultSkink in the *netscape* build script on the branch.
This doesn't look very clean to me as it appears that this method simply adds a
new line to installed-chrome.txt, so we'd end up with 2 such lines, and I'm not
sure which one would prevail.
3. use [2], but improve the SetDefaultSkin method to actually overwrite any
previous call to it and avoid duplicate entries in installed-chrome.txt. This
would be ideal but requires more Perl skills than I currenty have :-/
(read: I need help :-)
Comment 23•25 years ago
|
||
jj: i grep perl i can implement #3. i don't know if it'll be pretty, but i'll
attach a patch shortly.
Comment 24•25 years ago
|
||
here's the general idea, will have a real patch shortly:
sub SetDefaultSkin($)
{
my($skin) = @_;
my($filecontents);
# assertRightDirectory();
# my($dist_dir) = GetBinDirectory();
# my($chrome_subdir) = $dist_dir."Chrome";
print "Setting default skin to $skin\n";
open(CHROMEFILE, "installed-chrome.txt") || die "Failed to open installe
d_chrome.txt\n";
while(<CHROMEFILE>)
{
if (!/skin,install,select,(.*)/)
{
$filecontents .= $_;
}
else
{
$filecontents .= "skin,install,select,$skin\n";
}
}
close(CHROMEFILE);
open(CHROMEFILE, ">installed-chrome.txt") || die "Failed to open install
ed_chrome.txt\n";
print CHROMEFILE $filecontents;
}
Comment 25•25 years ago
|
||
Comment 26•25 years ago
|
||
jj, you forgot:
4. make modern the default skin on the trunk for mozilla and netscape.
who doesn't agree with this option?
| Assignee | ||
Comment 27•25 years ago
|
||
Asa, I would like your word on this.
At today's macdev meeting, everybody agreed that both Mozilla and Netscape
builds should default to Modern on Mac (classic & carbon).
If you agree with this, then the fix would be much simpler, limited to a 1-line
change in the mozilla script, and no change at all on the Netscape side:
< SetDefaultSkin("classic/1.0");
---
> SetDefaultSkin("modern/1.0");
Comment 28•25 years ago
|
||
Make it Modern everywhere.
Comment 29•25 years ago
|
||
ease up simon, you're not a mozilla.org person, so you don't get to say what
happens in the mozilla tree. jj's doing the right thing by requesting feedback
from asa on the right thing to do here.
Comment 30•25 years ago
|
||
Simon was just providing his feedback, as am I, make it Modern everywhere. When
Modern sucked it was nice to have the nice comfortable familiar Classic skin.
Now that Modern is fleshed out the Mac community at Netscape prefers it to
Classic, especially on OS X (as was discussed at the MacDev meeting yesterday)
Comment 31•25 years ago
|
||
I understand. I'm just pointing out that the Mac community at Netscape is not
the ultimate arbiter of what happens in the mozilla tree. So macdev can provide
make their opinion known, and implement it in the ns tree, but in the mozilla
tree the buck stops with mozilla.org, so JJ has to get approval from Asa or
another mozilla.org person before he can implement the change. If you'd like to
help the process along, I'd suggest tracking down a mozilla.organ to make the
call and have them comment in the bug.
Comment 32•25 years ago
|
||
maybe i'm just cranky today, but i'm geting a little confused with the double-
standard applied to the mac builds. When we came to mozilla and asked for
fizzilla on the main page, the consensus was that there were not enough external
developers warrant a community and the only people who were impacted were at
Netscape. Now we're asking for modern as the default and the answer is the
opposite: it's up to the mac mozilla community to decide.
Well which is it? Is there a mac mozilla community or not?
Comment 33•25 years ago
|
||
The correct way to solicit input from the mozilla community would be to make a
post to news://netscape.public.mozilla.mac about making Modern the default skin.
I have not seen this happen.
Comment 34•25 years ago
|
||
two sides of the same coin. if mozilla doesn't want an OS X tinderbox to block
development, it doesn't go on the main page. if they don't want modern as the
default skin, then it doesn't go in. Netscape controls the ns tree and NS6
builds. Mozilla controls the mozilla tree and the Mozilla builds. Asa clearly
stated above (2001-09-13 22:00) that he doesn't want Modern to be default. So
you don't have to convince me, you have to convince him. Netscape doesn't
dictate to mozilla.org, we try to work together to make sure things get done.
But if mozilla doesn't want something, we have to work around it, just like
everyone else. Right now that means changing the Netscape OS X build to do
modern and leaving mozilla alone (unless you can convince Asa to change his
mind), just like it means no fizilla on the SeaMonkey page (and why we have a
rush order for 5 new G4s to create Netscape OS X tinderboxen).
| Assignee | ||
Comment 36•25 years ago
|
||
debate posted to netscape.public.mozilla.org:
news://news.mozilla.org:119/3BA7A948.8090904@netscape.com
Comment 37•25 years ago
|
||
For what it's worth, I agree with Asa, for a number of reasons ...
(1) Mozilla (unlike Netscape) has practically no need for branding, and
therefore no need to make itself look gratuitously different from other
applications running on the user's system.
(2) From a pragmatic point of view, having Mozilla builds default to Classic
-- while Netscape builds default to Modern -- helps smoke out skinability
bugs by ensuring that many eyes are being exposed to each theme.
(3) Now that the latest incarnations of all Mozilla's first-tier target
platforms have built-in support for platform-global themes, Mozilla will
continue to be annoying (no matter what its own default theme is) until it
respects those themes. Classic at least tries to do this with fonts and
colors (and will do a much better job when theme:// is implemented),
whereas Modern just sulks.
(4) There are some bugs in Modern which can't be fixed as long as it remains a
cross-platform theme; for example, the Tab key in Modern on the Mac (like
in Modern everywhere) cycles through all widgets in chrome, annoying those
who expect the behavior they're used to from every other program on Mac OS
(cycling through only text fields and listboxes).
(5) Even with the lack of polish Classic has received in comparison with Modern
(an imbalance which I'm told is going to be redressed soon), Classic is
still just plain more usable -- due to its use of color to distinguish
toolbar icons, more easily recognizable alert icons, higher contrast
between chrome text and background, and larger and easier to click toolbar
menubuttons.
Comment 38•25 years ago
|
||
mpt:
(1) the classic skin looks _so_ out of place on OSX. It would be a joke to ship
it. Even apple prefers modern.
(4) this is for accessibility, not a bug.
Updated•25 years ago
|
Whiteboard: PDT+ → PDT+ [OSX+]
| Assignee | ||
Comment 39•25 years ago
|
||
based on comments made here and on netscape.public.mozilla.mac, here's what I
suggest:
- Mozilla for MacOS 8/9 : stick with Classic skin
- Mozilla for MacOS X : switch to Modern
- Netscape for all : switch to Modern
If this is ok, I'd like to move SetDefaultSkin() from MozillaBuildList.pm to a
file accessible from both Mozilla and Netscape build scripts to avoid code
duplication. (Moz::BuildUtils? use Moz::Moz?)
Whiteboard: PDT+ [OSX+] → PDT+
Comment 40•25 years ago
|
||
Just my feeling here?. but we Mac user whine, complain and b**** about how ugly
Mozilla is under OS X, as its not fitting in with the UI of OS X. With that said
more I use Modern it does fit into the OS X look (more or less) than does the
Aqua theme or the Classic theme. How I see it, Classic should not ship with any
mozilla.org product/project.
Bottom line one may not like classic or modern since neither have an aqua look.
The classic theme looks like a classic app? which fizzilla is not. I think jj?s
solution is a good compromise. Until someone is able to get that theme engine
idea working under OS X and provide a real time Aqua interface.
| Assignee | ||
Comment 41•25 years ago
|
||
While the debate goes on for the trunk, I will check in the one line change to
MozillaBuildList.pm on the 0.9.4 branch which is now owned by Netscape, as soon
as my test build with the fix completes and I can verify that a new profile
created with NS6 loads Modern by default.
Stay tuned.
| Assignee | ||
Comment 42•25 years ago
|
||
1-line fix checked in on the 0.9.4 branch (used cltbld account by mistake).
I'll submit a new patch for the trunk proposal.
feel free to udpate keuwords and tfv accordingly.
Comment 43•25 years ago
|
||
My vote is for Modern to be the default
1) It brings the Mac OS X theme default in line with the other OS theme defaults
2) It just plain looks better.
Comment 44•25 years ago
|
||
Chris Blackstone wrote:
>My vote is for Modern to be the default
>1) It brings the Mac OS X theme default in line with the other OS theme defaults
No it doesn't. It makes Mac OS X theme the only defauly _out_of_line_ with the
other OS theme defaults.
>2) It just plain looks better.
No it doesn't ;)
From a QA and testing standpoint this inconsistency is awkward. This would be
inconsistent with the other platforms. Mozilla provides binaries for testing
and development purposes and things that are done for esthetic reasons that make
testing more difficult don't happen. If Netscape wants to make it a default to
Modern like all the other Netscape releases I think that's great. Consistency is
nice (especially for QA). I don't think this should be switched for Mozilla
builds. Please do not change this for Mozilla. Thanks.
Comment 46•25 years ago
|
||
setting to 0.9.6 since this isn't blocking 0.9.5
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Comment 48•25 years ago
|
||
Re: Jaime's question, Suzanne, please verify this on the Mac commercial branch.
If ok (defaulting to Modern), then add to the status whiteboard "[Fixed and
verified on commercial builds on branch.]" Thanks. We'll leave this bug open
for the trunk decisions (which still seem to be discussed here).
| Reporter | ||
Comment 49•25 years ago
|
||
Yes, the default theme is modern on OSX now.
Verifying
Mac OSX 2001-10-15-11 0.9.4 Branch
Whiteboard: [PDT+] → [PDT+] [Fixed and verified on commercial builds on branch.]
Comment 50•25 years ago
|
||
since this is fixed and verified on the branch, removing nsbranch+ so it drops
off my list of open nsbranch+ bugs.
Keywords: nsbranch+
Comment 51•24 years ago
|
||
With 0.9.6 build 2001112002 on Mac OS X 10.1.1, new profiles created with
Profile Manager use the Classic skin by default.
Comment 52•24 years ago
|
||
Looks like this won't make it in for 0.9.6.
Updated•24 years ago
|
Target Milestone: mozilla0.9.6 → mozilla0.9.7
| Reporter | ||
Comment 54•24 years ago
|
||
This looks bad for IM in commercial.
Nominating nsbeta1
Keywords: nsbeta1
Comment 55•24 years ago
|
||
wait, mozilla defaulting to classic makes IM look bad? how on earth can that be?
commercial defaults to modern, does it not?
unless you're trying to say that the new theme work looks bad in aim.
| Reporter | ||
Comment 56•24 years ago
|
||
so..maybe i'll log a bug in bugscape?
Comment 57•24 years ago
|
||
removing old nsbeta1 and nsenterprise keywords.
Keywords: nsbeta1,
nsenterprise-
| Reporter | ||
Comment 58•24 years ago
|
||
Commercial defaults to classic/aqua theme & IM looks bad in it..
Is these both Bugscape bugs?
| Reporter | ||
Comment 59•24 years ago
|
||
IM bug has been logged for classic theme on OSX
(http://bugscape/show_bug.cgi?id=12034)
Looking for bugscape bug on OSX default theme for Commercial
Comment 60•24 years ago
|
||
I don't see any action here and am getting tired of punting this bug every
milestone. Resolving/fixed for now since the branch and netscape builds were
taken care of and Asa made it clear he wants the mozilla builds to be classic.
Severity: blocker → normal
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Priority: P1 → P2
Resolution: --- → FIXED
Whiteboard: [PDT+] [Fixed and verified on commercial builds on branch.] → [PDT+][Fixed on branch]
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•