Open Bug 919925 Opened 11 years ago Updated 9 years ago

Edit as new no longer works on attachments

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.21 affected, seamonkey2.24 affected)

Tracking Flags:
Tracking Status
seamonkey2.21 --- affected
seamonkey2.24 --- affected

People

(Reporter: paul_j, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0 SeaMonkey/2.21 (Beta/Release)
Build ID: 20130916112225

Steps to reproduce:

Bounce messages typically include the original message as an attachment.  In earlier versions of SeaMonkey, I was able to edit the attachment as a new email, either by opening it or from the context menu, and correct the error.

However, recent (maybe since 2.18 or so?) releases don't do anything when the menu option is selected.  The menu option is present and enabled, but nothing happens when you select it.

To repro, forward a message from your sent items folder to yourself as an attachment. Open the attachment and pick "Edit as new message" from the menu.


Actual results:

Nothing.  No error, no message in the error console, nothing.


Expected results:

Message composition window should have opened.

I also observed that the reply and forward buttons don't work.  I've never had cause to try those before, so I don't know if that's a new issue.  I used to use the edit as new quite often since Yahoo groups would bounce emails if I sent them using the wrong "from" address.
Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 SeaMonkey/2.24a1 ID:20130919003001 c-c:1ea1fc3586db m-c:803189f35921

I can reproduce this problem on Linux64 trunk as follows:
1. Open a message with an .eml attachment — I used an actual bounce sent to me after I had tried to send a test message to test@example.com
2. Right-click the attachment, then "Open"
3. Message → Edit Message as New

At step 3 (the menuitem is not greyed-out) nothing happens.

Wayne: can you reproduce this on Thunderbird?
Status: UNCONFIRMED → NEW
status-seamonkey2.21: --- → affected
status-seamonkey2.24: --- → affected
Ever confirmed: true
Flags: needinfo?(vseerror)
OS: Windows 7 → All
Hardware: x86_64 → All
Version: SeaMonkey 2.21 Branch → Trunk
I can confirm that Edit As New works correctly on TB24 beta channel, so this bug is not present in TB.
Flags: needinfo?(vseerror)
As this is an "external" message, gFolderDisplay.SelectedMessageUris returns an empty array.
gMessageDisplay.isDummy returns true, so potentially this could be tested for within folderDisplay's get selectedMessageUris() (http://mxr.mozilla.org/comm-central/source/suite/mailnews/folderDisplay.js#74) and return [gCurrentMessageUri] instead.
Neil might well know a better way of fixing this.
Flags: needinfo?(neil)
Assuming this is a regression, do we have any idea of the range, so we can look at what the code did before?
I'm guessing it's been broken for ~3 releases or so.  I kept thinking it would get reported and fixed.
Flags: needinfo?(neil)
Looking back, I'm going to guess this broke between 2.16 and 2.17
Same issue here on Windows 7 x64. It has been broken for several revisions.

I am currently at Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

If I take a previous email with attachments and 'Edit as new' and change the attachments and
text, when I go to send it just spins saying Attaching......
You need to log in before you can comment on or make changes to this bug.