Remove stale opacity:0 from animating tabs

RESOLVED FIXED in Firefox 28

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M9][Australis:P3])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I don't know if it was intentional that bug 919541 prevented closing tabs from being rendered at all (e.g. even when hovered by the mouse). This patch maintains that behavior, but gets rid of the now-redundant opacity setting.

I don't know if layout manages to optimize opacity:0 enough for it to be just as cheap as visibility:hidden. If it doesn't, this might be a slight perf win. I'm therefore picking a medium priority for this bug.
(Assignee)

Comment 1

5 years ago
Created attachment 809080 [details] [diff] [review]
patch
Attachment #809080 - Flags: review?(mconley)
Comment on attachment 809080 [details] [diff] [review]
patch

Review of attachment 809080 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I like this better. Thanks Dao.
Attachment #809080 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [Australis:P3] → [Australis:M9][Australis:P3][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/ba1db893d48a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P3][fixed-in-ux] → [Australis:M9][Australis:P3]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.