920037 - [Messages] In participant option menu, overlay display should only display unknown number/email once

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[isabelrios]

Reproduced on buri device while executing the test run. 
Gecko-4cde043
Gaia-a13c76f
Test Case #7139 

STR
Receive an SMS from a number not saved as a contact
Open the SMS
On the thread view, tap on the header where the number is shown

EXPECTED
The user should be prompted with a dialog when tapping on the number

ACTUAL
The dialog screen is shown, but there is an overlap with the number presented.
Please see screenshot attached

Comment 1

[isabelrios]

Attachment: 2013-06-01-00-44-44.png

Comment 3

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/12451

- Re-organize the assignment of OptionMenu params
- Clear params.section if the participant is an unknown participant
- Update tests
    - assert content of params.header value
    - assert that params.section is an empty string for unknown participants

Comment 4

[Julien Wajsberg [:julienw]]

Isabel, I don't see the overlap in current master?

I see twice the same number, which Rick's patch is removing, but I'd like to confirm the overlap is already fixed somewhere else, otherwise I may miss something.

Comment 5

[isabelrios]

Hi Julien, which device are you using? maybe it is because of the device...I could not see the overlap with unagi device with 1.2 or master, but the screenshot is with buri device.

Comment 6

[Julien Wajsberg [:julienw]]

it seems very strange to have different code path depending on the device.

Maybe again a case where our partners changed our code...

Comment 7

[Julien Wajsberg [:julienw]]

Comment on attachment 810025 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/12451

r=me provided travis is green (or at least "green enough")

You can handle my last comment if you want, but that's not mandatory, my head is not clear enough about whether it would be better.

Comment 8

[Rick Waldron [:rwaldron]]

gaia@master https://github.com/mozilla-b2g/gaia/commit/807f89083933ef32748e48da576d2a15f91faf23

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

triage: seem like a regression. koi+

Comment 10

[James Lal [:lightsofapollo]]

Uplifted 807f89083933ef32748e48da576d2a15f91faf23 to:
v1.2: a750cf2365a46f2e1ed0cbb8801b5c586a0e5ce6