920061 - Use explicit template instantiations instead of a hack

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Dan Gohman [:sunfish]]

Attachment: explicit-instantiate.patch

I just noticed the hack from bug 915998 and it turns out that there's a standard C++ way to do this. The attached patch implements it.

Comment 1

[Nicholas Nethercote [inactive]]

I swear I tried that, or something like it, at one point.

r=me if try server says it's ok.  Thanks!

Comment 2

[Dan Gohman [:sunfish]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/faef12754880

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 809209 [details] [diff] [review]
explicit-instantiate.patch

Review of attachment 809209 [details] [diff] [review]:
-----------------------------------------------------------------

Well, it didn't get backed out, so I'm assuming that this technique works fine. r=me

Comment 4

[Dan Gohman [:sunfish]]

Oops, I interpreted your earlier r=me as a review approval, conditional on a try run. I had collected what I judged to be sufficient try run data, so I checked it in. Thanks for your actual review approval :-}.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/faef12754880

Comment 6

[Nicholas Nethercote [inactive]]

> Oops, I interpreted your earlier r=me as a review approval, conditional on a
> try run.

That's what I meant... it appears I just forgot to change the checkbox to a '+' :)  Thanks for intervening, Terrence.

Comment 7

[Jeff Walden [:Waldo]]

(In reply to Dan Gohman [:sunfish] from comment #4)
> Oops, I interpreted your earlier r=me as a review approval, conditional on a
> try run. I had collected what I judged to be sufficient try run data, so I
> checked it in.

Usually we'd dump the try-run URL in here, so it's obvious that's happened.  :-)  Even if it is a partial run -- I assume people will see that "enough" confirmation was gotten in that case.