Closed Bug 920073 Opened 11 years ago Closed 11 years ago

Use nsString.h less

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: regression)

Attachments

(1 file)

Proposed patch
3.96 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
From bug 918923: We should use it instead of nsStringGlue.h in places which only use the internal APIs.

However a number of public headers which would normally be available to users of the external API were included in the list, to wit:
imgRequest.h
nsICharsetConverterManger.idl
nsIDateTimeFormat.h
nsIPlatformCharset.h
nsIScriptContext.h
nsIWidget.h
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #809445 -
        Flags: review?(ehsan)

    
    

    
  
Comment on attachment 809445 [details] [diff] [review]
Proposed patch

Sorry if this broke your builds. :/

        Attachment #809445 -
        Flags: review?(ehsan) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e044880511db
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27

    
    

    
  
nsIParserService.h is another file that bug 918923 changed, and is now causing me grief in external builds :(

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: