920128 - FTE skipping wireless network choice

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

On Unagi - flash 1.2/aurora 2013/09/24 (local build), and the first next skips the network selection and gets us to the time zone screen right away.  Pressing Back will get you to the wireless network choice.

No sim in the phone.

Comment 2

[Fernando Campo (:fcampo)]

not only happening on local builds.
Seems like a regression, so koi?
Adding people on the loop and asking for a window.

Also blocking what the duplicate blocked.

Comment 3

[Sarah Parsons]

This issue started to occur on the Buri 1.2 Aurora Build ID:20130918004001

Gaia   9b1b262e8fde58be453fb05ed91c0e93ab86d394
SourceStamp 0322470077b7
BuildID 20130918004001
Version 26.0a2

Last working Buri 1.2 Build ID: 20130916040205

Gaia   a0079597d510ce8ea0b9cbb02c506030510b9eeb
SourceStamp c4bcef90cef9
BuildID 20130916040205
Version 26.0a1

Comment 4

[Marina Rodríguez [:mai]]

Attachment: proposal v1

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Sounds like it is a regression, and we can't ship this way, so koi+

Comment 7

[Fernando Campo (:fcampo)]

Comment on attachment 813037 [details]
proposal v1

Linting is failing, and the state bar is showing incorrect steps when PIN is skipped or SIM is not present.

The rest looks good so far, and code is much cleaner now :)

Comment 8

[Fernando Campo (:fcampo)]

Comment on attachment 813037 [details]
proposal v1

Cool, thanks for solving it.

You got the +, assuming you will fix the nits on the tests

Comment 9

[Marina Rodríguez [:mai]]

Fixed the nits on the test ;)

Comment 10

[Fernando Campo (:fcampo)]

Comment on attachment 813037 [details]
proposal v1

So after last changes, I revised it and tested it again, and everything looks nice (for commit 3768526444360cfe2e30c07c52b64db03987b6b1)

We are good to merge

Comment 11

[Fernando Campo (:fcampo)]

Merged on master - 2a0d1f66a2756a5c4887da30025120029e866df2

\o/

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 2a0d1f66a2756a5c4887da30025120029e866df2
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 13

[Marina Rodríguez [:mai]]

Attachment: patch only for v1.2

I don't have rights to merge. This patch is only for v1.2.

Comment 14

[Fernando Campo (:fcampo)]

Comment on attachment 816625 [details]
patch only for v1.2

r+ed and merged on 1.2 64bb3d1b146e653293e669a24bc3775f09a217b1