Update the gaia-ui endurance settings and sms tests for master; update manifest

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Updates to the gaia-ui endurance tests (settings and sms tests) for latest changes in master; includes addition to the gaiatest messages app; update manifest.
(Assignee)

Comment 1

5 years ago
Created attachment 809366 [details] [review]
pull request pointer
Attachment #809366 - Flags: review?(bob.silverberg)
(Assignee)

Comment 2

5 years ago
:bsilverberg, requesting a review of the addition to the gaiatest message app, thanks!
Comment on attachment 809366 [details] [review]
pull request pointer

I have added me comments to the PR.
Attachment #809366 - Flags: review?(bob.silverberg) → review-
(Assignee)

Updated

5 years ago
Attachment #809366 - Flags: review- → review?(bob.silverberg)
Comment on attachment 809366 [details] [review]
pull request pointer

Comments in the pull request.
Attachment #809366 - Flags: review?(bob.silverberg) → review-
(Assignee)

Updated

5 years ago
Attachment #809366 - Flags: review- → review?(bob.silverberg)
Comment on attachment 809366 [details] [review]
pull request pointer

Comments in the PR.
Attachment #809366 - Flags: review?(bob.silverberg) → review-
(Assignee)

Comment 6

5 years ago
Comment on attachment 809366 [details] [review]
pull request pointer

Updated the pull request
Attachment #809366 - Flags: review- → review?(bob.silverberg)
Comment on attachment 809366 [details] [review]
pull request pointer

My last comment was just a question. The PR gets my r+ either way. For the changes to the app objects that is.
Attachment #809366 - Flags: review?(bob.silverberg) → review+
(Assignee)

Comment 8

5 years ago
Comment on attachment 809366 [details] [review]
pull request pointer

Thanks Bob.

Dave, would you mind doing a quick review of the rest of the changes in the pull request? Thanks!
Attachment #809366 - Flags: review+ → review?(dave.hunt)
Comment on attachment 809366 [details] [review]
pull request pointer

One minor PEP8 issue, but you can carry my r+
Please squash your commits before merging.
Attachment #809366 - Flags: review?(dave.hunt) → review+
(Assignee)

Comment 10

5 years ago
Thanks Dave. Squashed and merged.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.