920236 - Add a pref to display a page on first run after install/upgrade

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Install/Update, defect, P2)

Description

[Matt Brubeck (:mbrubeck)]

In order to implement our first-run experience (bug 916326), we need to add some code and prefs similar to desktop Firefox to open a URL in a tab on first run.

Comment 1

[Marina Samuel [:emtwo]]

Attachment: WIP: Show a 'first run' or 'upgrade' page

Since bug 916326 is set to [block28], I thought I'd take a look at this one.

It seems like most of the code to do this is already there except for some reason the line with '#expand' was not working. We could also do separate checks for "new profile" and "new version" if we want to have separate start pages in each case.

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 833031 [details] [diff] [review]
WIP: Show a 'first run' or 'upgrade' page

Looks good.  We'll probably use just "new profile" for now, and "new version" if we create a special upgrade page in the future.  We'll need to work with Yuan and/or webdev or SUMO to figure out what the URL will be for the first-run page.

Comment 3

[Allison Naaktgeboren :ally]

Did we ever sort out what the first run url should be? Is this bug actionable yet? Marina, do you still want this one?

Comment 4

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: WIP with about:start?firstrun

Same patch setting first run page to "about:start?firstrun".

Comment 5

[Marco Mucci [:MarcoM]]

Hey Rodrigo, can you provide a point value.

Comment 6

[Rodrigo Silveira [:rsilveira] [:rodms]]

p=1

Comment 7

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

Switched to about:newtab?firstrun

Comment 8

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8349609 [details] [diff] [review]
Patch v1

Review of attachment 8349609 [details] [diff] [review]:
-----------------------------------------------------------------

r=mbrubeck with a possible change:

::: browser/metro/components/BrowserCLH.js
@@ +222,5 @@
>          // Default to the saved homepage
>          let defaultURL = getHomePage();
>  
> +        // Show page for first run or upgrade.
> +        if (needHomepageOverride() != "none") {

Maybe we should do this only if (needHomepageOverride() == "new profile"), so that we don't show the firstrun page after every version upgrade.

That's assuming that it will return "new profile" the first time Metro Firefox runs, even in an existing desktop Firefox profile.  I think that's the case but I haven't tested it.

Comment 9

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v2

changed to using needHomepageOverride() == "new profile". Tested it and works fine even with a populated desktop profile.

Comment 10

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/fx-team/rev/425e560ef39a

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/425e560ef39a

Comment 12

[Rodrigo Silveira [:rsilveira] [:rodms]]

Comment on attachment 8349778 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): No regression, triggers first run experience in bug 941284.
User impact if declined: Low, first run experience will not be enabled.
Testing completed (on m-c, etc.): yes.
Risk to taking this patch (and alternatives if risky): Very low, metro change only.
String or IDL/UUID changes made by this patch: None.

Comment 13

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b165819fa20d

Comment 14

[Manuela Muntean [Away]]

Verified as fixed for iteration #21, with latest Nightly and Aurora on Win 8 64-bit and 32-bit: after install/upgrade, the "about:start?firstrun" page is displayed.