Tie SkiaGL texture lifetime to that of the bitmap

RESOLVED INACTIVE

Status

()

Core
Canvas: 2D
RESOLVED INACTIVE
5 years ago
22 hours ago

People

(Reporter: snorp, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Right now when you do something like drawImage() with a SkiaGL-backed canvas, we have some caching behavior that is less than ideal. First of all, we cache the moz2d SourceSurface ourselves. With SkiaGL, this contains a SkBitmap. Once you draw this, as drawImage() does, there is a texture in the Skia texture cache as well. Our SourceSurface cache appears to expire things after a period of time has elapsed. The Skia one is LRU. So once you hit the maximum texture cache size, it's going to stay there forever (at least for that GrContext/DrawTarget).

We should simply tie the texture to the bitmap. That way we really just have the one SourceSurface cache eating up memory.

Comment 1

22 hours ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Last Resolved: 22 hours ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.