aria labels are unlocalizable

RESOLVED FIXED

Status

Firefox OS
Gaia
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
ARIA labels don't have a field in the DOM API, so elem.ariaLabel won't actually affect the element.

A special case for aria attributes needs to be added where l10n would use setAttribute instead of simply setting the DOM element field.
(Assignee)

Comment 1

5 years ago
As far as I can tell, aria-label is the only aria attribute that has strings read by humans, so it really just needs its own special case.
(Assignee)

Comment 2

5 years ago
Created attachment 809462 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12407

Pointer to Github pull-request
(Assignee)

Updated

5 years ago
Attachment #809462 - Flags: review?(kaze)
(Assignee)

Comment 3

4 years ago
Any decisions about this?
(Assignee)

Updated

4 years ago
Attachment #809462 - Flags: review?(kaze) → review?(felash)
Comment on attachment 809462 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12407

r=me

go for it !
thanks :)
Attachment #809462 - Flags: review?(felash) → review+
(Assignee)

Updated

4 years ago
Assignee: nobody → eitan
(Assignee)

Comment 5

4 years ago
https://github.com/mozilla-b2g/gaia/commit/c6d417ab0b88eee9b6ecebe11dd81bf896d22f35

Thanks!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.