920261 - [email] 'mailto' links including linkified e-mail addresses broken in e-mail app by support of URL sharing activity from browser (bug 821519)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

From https://bugzilla.mozilla.org/show_bug.cgi?id=821519#c21:
===
[bug 821519] broke mailto links, including those produced by the e-mail app's own linkification logic.

The bit that does this in the patch:
+      if (dataType === 'url') {
+        data.body = url;
+      } else { 

Is wrong because we (and presumably the browser?) use window.open() to open hyperlinks, including mailto URL's that we create.  popup_manager.js in the system app transforms the open call to an activity of the form: { name: 'view', data: { type: 'url', url: <theurl> } }

We should probably only be going into that 'copy the URL case verbatim' logic if the activity type is 'share'.
===

We probably want the following tests:

- Higher level compose-triggered-from-an-activity unit-tests that provide known activity input types and ensure that we setup the composer appropriately.  (Right now mail_app_test.js only does low level mailto URI parsing.)

- Integration test for displaying a message with e-mail addresses (text/plain and text/html) that results in linkification and verifies that clicking on the links triggers prompts and appropriate compose cards.

- Integration test for clicking on a mailto link from the browser and that it causes an appropriate compose card in the e-mail app.

Comment 1

[Dylan Oliver [:doliver]]

koi+ for regression

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12992

Pointer to Github pull-request

Comment 4

[James Burke [:jrburke]]

Comment on attachment 821925 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12992

Left a comment about a suggestion for a better encapsulated test helper method, and with that change done r+ from me.

With the tests in this changeset, and my previous changeset for bug 925174, there are now an integration test for each of the "view", "share" and "new" activity entry point types. Along with existing unit tests for query_uri, I think that gets a bare minimum test coverage. 

If you prefer to do more tests as :asuth suggested in bug description, mainly around a more complicated mailto: link with more email parts in it, and an email message that has a mailto link, both checking what ends up in the actual Compose card, I am all for that. I leave it to you though if you have other priorities that need your attention. Feel free to ping me again for review if you decide add more tests.

For any email message composition setup, email's notification_click_test.js has a sendEmail function that could be helpful.

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

landed on master 5387ea6411c669a262de0914f6a196055449c5b9

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 5387ea6411c669a262de0914f6a196055449c5b9
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

I went ahead and fixed the merge conflicts manually. Thanks ford-bot!

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

For reference, 473b6570521fa04eecec83a27cd7c4bbe25d0555 is the commit on v1.2

Comment 9

[Peter Bylenga [:PBylenga]]

Verified Fixed: Utilizing mailto links in browser invokes email app to compose message and returns afterwards.


Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20131107004003
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/26f1e160e696
Gaia: 590eb598aacf1e2136b2b6aca5c3124557a365ca
Platform Version: 26.0
RIL Version: 01.01.00.019.281 
Firmware Version: US_20131104