Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla27
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 809517 [details] [diff] [review]
dumpstack

I fixed paramters and kind of fixed locals. For some reason all the values are undefined, is that because of an optimization?
Attachment #809517 - Flags: feedback?(jdemooij)
(Assignee)

Comment 1

5 years ago
So I don't really remember what Jan told me, but I think it boiled down to that supporting this for the JITs needs some work. Also I think he recommended using something different from debug scopes. Jan would you mind clarifying this again? :)
Flags: needinfo?(jdemooij)
Comment on attachment 809517 [details] [diff] [review]
dumpstack

Review of attachment 809517 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Tom Schuster [:evilpie] from comment #1)
> So I don't really remember what Jan told me, but I think it boiled down to
> that supporting this for the JITs needs some work. Also I think he
> recommended using something different from debug scopes. Jan would you mind
> clarifying this again? :)

Yeah I wouldn't use GetDebugScopeForFrame here. I think you can just add a ScriptFrameIter::unaliasedLocal method like the unaliasedActual method you're already using.

Note that these methods work fine for Interpreter and Baseline frames but will assert for Ion frames I think, so please make sure you're handling that correctly (the simplest thing to do is to not print args/locals if iter.isIon()).
Attachment #809517 - Flags: feedback?(jdemooij)

Updated

5 years ago
Flags: needinfo?(jdemooij)
(Assignee)

Comment 3

5 years ago
Created attachment 812250 [details] [diff] [review]
wip v2

Made some progress here, I think right now I am missing something like AliasedFormalIter but for formals.
Assignee: nobody → evilpies
Attachment #809517 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(Assignee)

Comment 4

5 years ago
Oh looks like the locals are wrong even for simple functions, need to investigate this more.
(Assignee)

Comment 5

5 years ago
Maybe we can just punt on locals and fix the arguments at least?
(Assignee)

Comment 6

5 years ago
Created attachment 822244 [details] [diff] [review]
v1
Attachment #812250 - Attachment is obsolete: true
Attachment #822244 - Flags: review?(jdemooij)

Updated

5 years ago
Attachment #822244 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/1268bd66a094
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.