920331 - More intelligent abort conditions for favicon loading in tabs

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Favicon Handling, defect)

Description

[Chris Kitching [:ckitching]]

Followup to Bug 914296. Depends thereon. Assigned to me (Having a few bugzilla permissions issues - apparently us mere mortals without @mozilla.com emails on our bugzilla accounts can't set these fields...)

In BrowserApp.java, in the definition for the listener function for favicon load, the following check exists:

if (!tab.getURL().equals(pageUrl)) 

If true, the loaded result is discarded.

After the resolution of Bug 834536, this is no longer correct. The pageURL may have changed, but the favicon URL may very well be the same.
It would seem that a sensible way to proceed is to have the listener get passed the favicon URL as well as the page URL. That way, the decision to bin the result can be made based on this.

Comment 1

[Chris Kitching [:ckitching]]

Seems to be cured as a side-effect of Bug 914027. Yay for another umbrella-bug.

Comment 2

[Richard Newman [:rnewman]]

See also Bug 931843 Comment 46 -- we should have an "isSuitableFaviconForPage" method or something.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.