Closed
Bug 920337
Opened 11 years ago
Closed 11 years ago
Race when loading projects
Categories
(DevTools Graveyard :: WebIDE, defect, P1)
DevTools Graveyard
WebIDE
Tracking
(firefox26 fixed, firefox27 fixed)
RESOLVED
FIXED
Firefox 27
People
(Reporter: jryans, Assigned: jryans)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.11 KB,
patch
|
paul
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
It's possible for AppProjects to finish loading the projects before UI.init in projects.js runs, which prevents the projects from ever being validated.
|
Assignee | |
Comment 1•11 years ago
|
||
Instead of watching an event from the store that may never arrive, use a promise to be sure we validate the projects.
Attachment #809603 -
Flags: review?(paul)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=e91f943e1b58
|
||
Updated•11 years ago
|
Attachment #809603 -
Flags: review?(paul) → review+
|
|
||
Updated•11 years ago
|
Whiteboard: [needed-in-aurora-26]
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a0f892c84c7e
Keywords: checkin-needed
Whiteboard: [needed-in-aurora-26] → [needed-in-aurora-26][fixed-in-fx-team]
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 809603 [details] [diff] [review] Use promise to ensure we don't miss project load [Approval Request Comment] Bug caused by (feature/regressing bug #): new feature (app manager) User impact if declined: some projects might not load Testing completed (on m-c, etc.): fx-team Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #809603 -
Flags: approval-mozilla-aurora?
|
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a0f892c84c7e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [needed-in-aurora-26][fixed-in-fx-team] → [needed-in-aurora-26]
Target Milestone: --- → Firefox 27
|
||
Updated•11 years ago
|
Attachment #809603 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Updated•11 years ago
|
Whiteboard: [needed-in-aurora-26] → [land-in-aurora-26]
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•