920337 - Race when loading projects

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It's possible for AppProjects to finish loading the projects before UI.init in projects.js runs, which prevents the projects from ever being validated.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Use promise to ensure we don't miss project load

Instead of watching an event from the store that may never arrive, use a promise to be sure we validate the projects.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=e91f943e1b58

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/a0f892c84c7e

Comment 4

[Paul Rouget [:paul]]

Comment on attachment 809603 [details] [diff] [review]
Use promise to ensure we don't miss project load

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: some projects might not load
Testing completed (on m-c, etc.): fx-team
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0f892c84c7e

Comment 6

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8551e8776ede