920346 - PYTHONPATH not unset if no previous PYTHONPATH existed.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[vinod.chandru]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130910160258

Steps to reproduce:

$ echo $PYTHONPATH
# Blank, since I have nothing set
$ source bin/activate
(addon-sdk-1.14)$ deactivate
$ echo $PYTHONPATH


Actual results:

PYTHONPATH is still set.


Expected results:

PYTHONPATH should have been unset. To fix it, I removed the conditional unset in deactivate() in bin/activate to always set PYTHONPATH to _OLD_PYTHONPATH.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Reporter, would you be willing to submit a patch with your change?

Comment 2

[vinod.chandru]

Sure. Pull Request here: https://github.com/mozilla/addon-sdk/pull/1256

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Dave, who should review that pull request? The last people to touch bin/activate were myk and other original Jetpack team people that aren't working on this anymore.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/14e52e046676bf9935489ef6a4e6932653542b9f
Bug 920346 - Setting PYTHONPATH to original value even if original was blank.

https://github.com/mozilla/addon-sdk/commit/7bd1db05c4c2218eb60bb30c50adabcf8f252256
Merge pull request #1256 from vinodc/pythonpath

Bug 920346 - Set PYTHONPATH to original value even if original was blank. r=Mossop

Comment 5

[Dave Townsend [:mossop]]

Nice work, thanks