920410 - Investigate why controller.select() works by just issuing a click() command on the item without first opening the select / dropdown / XULMenuList

Status: RESOLVED WONTFIX

(Testing Graveyard :: Mozmill, defect, P3)

Description

[Andrei Eftimie]

As a solution for bug 912941 we found that we can safely select an item from a select / dropdown / XULMenuList by just issuing a click() command on the wanted item.

This *should not* work as the item is not visible without first opening the parent first.
The solution used in bug 912941 works remarkably well, and we should figure out why, and patch the controller.select() method if a better alternative is found (one that more closely resembles an actual use of the specified UI element)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: try to use objdump if possible in dependentlibs.py

With this patch, all the patches from dependent bugs, a mozconfig like:

CROSS_LD_PATH=/home/froydnj/src/ld64.git/
CROSS_SYSROOT=/opt/build/froydnj/OSX-10.6-SDK
CROSS_PRIVATE_FRAMEWORKS=/opt/build/froydnj/PrivateFrameworks
FLAGS="-target x86_64-apple-darwin -mlinker-version=136 -B $CROSS_LD_PATH"

export HOST_CC=gcc
export HOST_CXX=g++
export HOST_LDFLAGS="-g"

export LDFLAGS="-Wl,-syslibroot,$CROSS_SYSROOT -Wl,-dead_strip"
export CC="clang $FLAGS"
export CXX="clang++ $FLAGS"
export CPP="clang $FLAGS -E"

CROSS_TOOLS_PREFIX=/opt/build/froydnj/darwin-crosstools/bin/x86_64-apple-darwin
export AR=${CROSS_TOOLS_PREFIX}-ar
export RANLIB=${CROSS_TOOLS_PREFIX}-ranlib
export STRIP=${CROSS_TOOLS_PREFIX}-strip

export CROSS_COMPILE=1

ac_add_options --target=x86_64-apple-darwin11
ac_add_options --with-macos-sdk=$CROSS_SYSROOT
ac_add_options --with-macos-private-frameworks=$CROSS_PRIVATE_FRAMEWORKS
ac_add_options --enable-debug
ac_add_options --disable-optimize
ac_add_options --without-intl-api
ac_add_options --disable-crashreporter
ac_add_options --disable-webrtc

an a Mach-O objdump at ${CROSS_TOOLS_PREFIX}-objdump, I'm able to complete the
build.  Then, on some Mac, I can do:

mac$ mkdir cross-dist
mac$ cd cross-dist
mac$ ssh $build_machine 'cd $objdir/dist; tar cf - . -h' | gtar xf -
mac$ open ./NightlyDebug.app

and voilà!  Working Mac Firefox compiled on a Linux machine.

This doesn't address uses of otool elsewhere in the tree or in
third-party projects.  It may be worth just using cctools for otool (and
ar/ranlib) to minimize pain for ourselves and/or other people.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 825327 [details] [diff] [review]
try to use objdump if possible in dependentlibs.py

Argh, wrong bug!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 02/17 - 02/21)]

Mozmill will reach its end of life soon. We are currently working on getting all the tests for Firefox ported to Marionette. For status updates please see bug 1080766.