Closed Bug 920439 Opened 11 years ago Closed 11 years ago

Whitelist "AsyncShutdownTimeout" metadata field

Categories

(Socorro :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Yoric, Assigned: peterbe)

References

Details

Once bug 917764 has landed, the Crash Reporter will send new data with key "AsyncShutdown Timeout". We should collect that data.
I don't know what your actual request is here, all data, including annotations, is collected by Socorro anyhow. And work is going on to be able to expose all of the annotations (though some whitelisting might be needed).
My bad. So instead of collecting that key, what I request is that we expose/report it.
(In reply to David Rajchenbach Teller [:Yoric] from comment #2) > My bad. So instead of collecting that key, what I request is that we > expose/report it. Where? In the UI? In the API? In which places there?
Summary: CrashReporter key "AsyncShutdown Timeout". → Expose "AsyncShutdownTimeout"
I was thinking of the UI. I am not familiar enough with Socorro to ask for anything further.
Summary: Expose "AsyncShutdownTimeout" → Expose "AsyncShutdown Timeout"
Should we wait for this bug before landing bug 917764?
Summary: Expose "AsyncShutdown Timeout" → Expose "AsyncShutdownTimeout"
(In reply to David Rajchenbach Teller [:Yoric] from comment #5) > Should we wait for this bug before landing bug 917764? No, you should land the other as you like, this can be done any time. Actually, having reports come in with that field already makes it easier to implement this bug here.
We should just fix bug 908469 (ASAP). This bug should be about adding AsyncShutdownTimeout to the API whitelist so that it is public and is available from the API and UI.
Summary: Expose "AsyncShutdownTimeout" → Whitelist "AsyncShutdownTimeout" metadata field
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/f57bee641201463a8f71e0faf5ba95a97176d541 bug 920439 - Whitelist "AsyncShutdownTimeout" metadata field, r=brandonsavage
To make this verify'able, do you know a UUID that whose raw crash data should contain a AsyncShutdownTimeout field?
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
This will require creating a custom version of Firefox. I will try and build one early next week.
Flags: needinfo?(dteller)
Assignee: nobody → peterbe
Target Milestone: --- → 61
I realize that I have no idea how I can enable the crash reporter. My custom build failed to upload a crash report because "The application did not identify itself". Does anyone have a clue?
Flags: needinfo?(dteller)
The crash reporter is enabled by default nowadays. How were you causing the crash?
nsIDebug::crash from JS, in a custom build
Ok, here we go: https://crash-stats.mozilla.com/report/index/bp-847f69ee-eb9a-4809-8a04-ed6112131001 This crash signature exposes a crash in phase |"testing-a-crash" + Math.random()| caused by blocker "This phase will crash".
Note that I don't see AsyncShutdownTimeout anywhere on that link.
I don't see it either. I am almost sure that I saw it before uploading, though.
Ah, ignore my latest comment, I had misread the future tense.
raw JSON shows that the data is present at least: "AsyncShutdownTimeout": "{\"phase\":\"testing-a-crash0.9285946030146887\",\"conditions\":[\"This phase will crash\"]}",
That's good. Is there a way to be Cc-ed automatically if the bug contains field AsyncShutdownTimeout?
Not really, no. If a new topcrash appears, I can make sure you are cc'ed on the bug. Later this quarter once bug 889040 is done, you'll be able to do queries yourself. In the meantime if you want the data you'll have to get somebody to run a query directly on the database (cc me on the data request bug).
You need to log in before you can comment on or make changes to this bug.