920439 - Whitelist "AsyncShutdownTimeout" metadata field

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[David Teller [:Yoric] - still alive but not very active]

Once bug 917764 has landed, the Crash Reporter will send new data with key "AsyncShutdown Timeout". We should collect that data.

Comment 1

[Robert Kaiser]

I don't know what your actual request is here, all data, including annotations, is collected by Socorro anyhow. And work is going on to be able to expose all of the annotations (though some whitelisting might be needed).

Comment 2

[David Teller [:Yoric] - still alive but not very active]

My bad. So instead of collecting that key, what I request is that we expose/report it.

Comment 3

[Robert Kaiser]

(In reply to David Rajchenbach Teller [:Yoric] from comment #2)
> My bad. So instead of collecting that key, what I request is that we
> expose/report it.

Where? In the UI? In the API? In which places there?

Comment 4

[David Teller [:Yoric] - still alive but not very active]

I was thinking of the UI. I am not familiar enough with Socorro to ask for anything further.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Should we wait for this bug before landing bug 917764?

Comment 6

[Robert Kaiser]

(In reply to David Rajchenbach Teller [:Yoric] from comment #5)
> Should we wait for this bug before landing bug 917764?

No, you should land the other as you like, this can be done any time. Actually, having reports come in with that field already makes it easier to implement this bug here.

Comment 7

[Benjamin Smedberg]

We should just fix bug 908469 (ASAP). This bug should be about adding AsyncShutdownTimeout to the API whitelist so that it is public and is available from the API and UI.

Comment 8

[Peter Bengtsson [:peterbe]]

PR https://github.com/mozilla/socorro/pull/1546

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f57bee641201463a8f71e0faf5ba95a97176d541
bug 920439 - Whitelist "AsyncShutdownTimeout" metadata field, r=brandonsavage

Comment 10

[Peter Bengtsson [:peterbe]]

To make this verify'able, do you know a UUID that whose raw crash data should contain a AsyncShutdownTimeout field?

Comment 11

[David Teller [:Yoric] - still alive but not very active]

This will require creating a custom version of Firefox. I will try and build one early next week.

Comment 12

[David Teller [:Yoric] - still alive but not very active]

I realize that I have no idea how I can enable the crash reporter. My custom build failed to upload a crash report because "The application did not identify itself". Does anyone have a clue?

Comment 13

[(not currently active) Ted Mielczarek]

The crash reporter is enabled by default nowadays. How were you causing the crash?

Comment 14

[David Teller [:Yoric] - still alive but not very active]

nsIDebug::crash from JS, in a custom build

Comment 15

[David Teller [:Yoric] - still alive but not very active]

Ok, here we go:
https://crash-stats.mozilla.com/report/index/bp-847f69ee-eb9a-4809-8a04-ed6112131001

This crash signature exposes a crash in phase |"testing-a-crash" + Math.random()| caused by blocker "This phase will crash".

Comment 16

[David Teller [:Yoric] - still alive but not very active]

Note that I don't see AsyncShutdownTimeout anywhere on that link.

Comment 17

[Peter Bengtsson [:peterbe]]

https://github.com/mozilla/socorro/commit/f57bee641201463a8f71e0faf5ba95a97176d541 hasn't made it to production yet. 

More importantly, where you can expect to see it will be on the JSON API here:
https://crash-stats.mozilla.com/api/RawCrash/?crash_id=847f69ee-eb9a-4809-8a04-ed6112131001&format=meta

Comment 18

[David Teller [:Yoric] - still alive but not very active]

I don't see it either. I am almost sure that I saw it before uploading, though.

Comment 19

[David Teller [:Yoric] - still alive but not very active]

Ah, ignore my latest comment, I had misread the future tense.

Comment 20

[Benjamin Smedberg]

raw JSON shows that the data is present at least: "AsyncShutdownTimeout": "{\"phase\":\"testing-a-crash0.9285946030146887\",\"conditions\":[\"This phase will crash\"]}",

Comment 21

[David Teller [:Yoric] - still alive but not very active]

That's good.
Is there a way to be Cc-ed automatically if the bug contains field AsyncShutdownTimeout?

Comment 22

[Benjamin Smedberg]

Not really, no. If a new topcrash appears, I can make sure you are cc'ed on the bug.

Later this quarter once bug 889040 is done, you'll be able to do queries yourself. In the meantime if you want the data you'll have to get somebody to run a query directly on the database (cc me on the data request bug).