Closed Bug 920495 Opened 6 years ago Closed 6 years ago

don't scrollIntoView when the basic inspector is used

Categories

(DevTools :: WebIDE, defect, P1)

x86
All
defect

Tracking

(firefox26 verified, firefox27 verified)

VERIFIED FIXED
Firefox 27
Tracking Status
firefox26 --- verified
firefox27 --- verified

People

(Reporter: paul, Assigned: paul)

Details

Attachments

(2 files)

This is very annoying. It moves the page every time an element is selected.
Attached patch Patch v1Splinter Review
I'll re-enable scrollIntoView later (bug 920984).
Attachment #810516 - Flags: review?(mratcliffe)
Whiteboard: [needed-in-aurora-26]
Comment on attachment 810516 [details] [diff] [review]
Patch v1

Review of attachment 810516 [details] [diff] [review]:
-----------------------------------------------------------------

Couldn't be simpler, r+
Attachment #810516 - Flags: review?(mratcliffe) → review+
Comment on attachment 810516 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (remote inspector)
User impact if declined: screen keeps scrolling when inspecting a fxos phone
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none
Attachment #810516 - Flags: approval-mozilla-aurora?
Keywords: checkin-needed
This landed with the wrong bug # in the commit message. Backed out and re-landed.
https://hg.mozilla.org/integration/fx-team/rev/8a975713796d
Whiteboard: [needed-in-aurora-26] → [needed-in-aurora-26][fixed-in-fx-team]
[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (remote inspector)
User impact if declined: screen keeps scrolling when inspecting a fxos phone
Testing completed (on m-c, etc.): fx-team
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none
Attachment #810587 - Flags: approval-mozilla-aurora?
Attachment #810516 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/8a975713796d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [needed-in-aurora-26][fixed-in-fx-team] → [needed-in-aurora-26]
Target Milestone: --- → Firefox 27
Attachment #810587 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [needed-in-aurora-26] → [land-in-aurora-26]
Keywords: verifyme
Tested on the 9/25 Firefox 26.0a2 and on Firefox 26.0b3:

Ubuntu 13.04 32bit - both builds work the same: when I select an element, the Inspector scrolls to bring its code into view; when I go through the inspector and select some code for another element, no scrolling happens in the simulator.

Mac OS X 10.9 - both builds work the same: I can't select elements with the mouse; when I go through the Inspector and select some code, no scrolling happens in the simulator.

Windows 7 64bit - 26.0a2 worked sometimes like on Mac, other times like on Ubuntu. 26.0b3 worked the same as on Ubuntu.

The Inspector used for desktop builds scrolls to the code for the selected item and, when selecting code in it, the web page scrolls to the corresponding item. How much of this behavior should the Inspector used with the App Manager display?
Flags: needinfo?(paul)
(In reply to Ioana Budnar, QA [:ioana] from comment #8)
> Tested on the 9/25 Firefox 26.0a2 and on Firefox 26.0b3:
> 
> Ubuntu 13.04 32bit - both builds work the same: when I select an element,
> the Inspector scrolls to bring its code into view; when I go through the
> inspector and select some code for another element, no scrolling happens in
> the simulator.

Good.

> Mac OS X 10.9 - both builds work the same: I can't select elements with the
> mouse;

In the inspector?

> when I go through the Inspector and select some code, no scrolling
> happens in the simulator.

Good.

> Windows 7 64bit - 26.0a2 worked sometimes like on Mac, other times like on
> Ubuntu. 26.0b3 worked the same as on Ubuntu.

Which version of the Simulator do you use?
Flags: needinfo?(paul)
(In reply to Paul Rouget [:paul] from comment #9)
> (In reply to Ioana Budnar, QA [:ioana] from comment #8)
> > Tested on the 9/25 Firefox 26.0a2 and on Firefox 26.0b3:
> 
> > Mac OS X 10.9 - both builds work the same: I can't select elements with the
> > mouse;
> 
> In the inspector?

No, in the simulator. I clicked the "Select element with mouse" button in the Inspector, then I tried to select an element in the app opened on the simulator. I can select elements in the Inspector - this part works the same as on Ubuntu.

> > Windows 7 64bit - 26.0a2 worked sometimes like on Mac, other times like on
> > Ubuntu. 26.0b3 worked the same as on Ubuntu.
> 
> Which version of the Simulator do you use?

I used 1.3 (couldn't get connected to 1.2 at the time).
QA Contact: developer.tools → ioana.budnar
Verified as fixed on the 12/04 Aurora on Windows 7 64bit, Mac OS X 10.9 and Ubuntu 13.04 32bit.

On all OSs, when I click an element in the app, the code in the Inspector is scrolled to that element. When I click the code for an element in the Inspector, the app doesn't scroll to that element.

I tested using the 1.2 simulator.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.