920495 - don't scrollIntoView when the basic inspector is used

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Description

[Paul Rouget [:paul]]

This is very annoying. It moves the page every time an element is selected.

Comment 1

[Paul Rouget [:paul]]

Attachment: Patch v1

I'll re-enable scrollIntoView later (bug 920984).

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 810516 [details] [diff] [review]
Patch v1

Review of attachment 810516 [details] [diff] [review]:
-----------------------------------------------------------------

Couldn't be simpler, r+

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 810516 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (remote inspector)
User impact if declined: screen keeps scrolling when inspecting a fxos phone
Testing completed (on m-c, etc.): locally
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This landed with the wrong bug # in the commit message. Backed out and re-landed.
https://hg.mozilla.org/integration/fx-team/rev/8a975713796d

Comment 5

[Paul Rouget [:paul]]

Attachment: Patch v1 with the correct commit message

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (remote inspector)
User impact if declined: screen keeps scrolling when inspecting a fxos phone
Testing completed (on m-c, etc.): fx-team
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a975713796d

Comment 7

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/446c4bbfa38f

Comment 8

[Ioana (away)]

Tested on the 9/25 Firefox 26.0a2 and on Firefox 26.0b3:

Ubuntu 13.04 32bit - both builds work the same: when I select an element, the Inspector scrolls to bring its code into view; when I go through the inspector and select some code for another element, no scrolling happens in the simulator.

Mac OS X 10.9 - both builds work the same: I can't select elements with the mouse; when I go through the Inspector and select some code, no scrolling happens in the simulator.

Windows 7 64bit - 26.0a2 worked sometimes like on Mac, other times like on Ubuntu. 26.0b3 worked the same as on Ubuntu.

The Inspector used for desktop builds scrolls to the code for the selected item and, when selecting code in it, the web page scrolls to the corresponding item. How much of this behavior should the Inspector used with the App Manager display?

Comment 9

[Paul Rouget [:paul]]

(In reply to Ioana Budnar, QA [:ioana] from comment #8)
> Tested on the 9/25 Firefox 26.0a2 and on Firefox 26.0b3:
> 
> Ubuntu 13.04 32bit - both builds work the same: when I select an element,
> the Inspector scrolls to bring its code into view; when I go through the
> inspector and select some code for another element, no scrolling happens in
> the simulator.

Good.

> Mac OS X 10.9 - both builds work the same: I can't select elements with the
> mouse;

In the inspector?

> when I go through the Inspector and select some code, no scrolling
> happens in the simulator.

Good.

> Windows 7 64bit - 26.0a2 worked sometimes like on Mac, other times like on
> Ubuntu. 26.0b3 worked the same as on Ubuntu.

Which version of the Simulator do you use?

Comment 10

[Ioana (away)]

(In reply to Paul Rouget [:paul] from comment #9)
> (In reply to Ioana Budnar, QA [:ioana] from comment #8)
> > Tested on the 9/25 Firefox 26.0a2 and on Firefox 26.0b3:
> 
> > Mac OS X 10.9 - both builds work the same: I can't select elements with the
> > mouse;
> 
> In the inspector?

No, in the simulator. I clicked the "Select element with mouse" button in the Inspector, then I tried to select an element in the app opened on the simulator. I can select elements in the Inspector - this part works the same as on Ubuntu.

> > Windows 7 64bit - 26.0a2 worked sometimes like on Mac, other times like on
> > Ubuntu. 26.0b3 worked the same as on Ubuntu.
> 
> Which version of the Simulator do you use?

I used 1.3 (couldn't get connected to 1.2 at the time).

Comment 11

[Ioana (away)]

Verified as fixed on the 12/04 Aurora on Windows 7 64bit, Mac OS X 10.9 and Ubuntu 13.04 32bit.

On all OSs, when I click an element in the app, the code in the Inspector is scrolled to that element. When I click the code for an element in the Inspector, the app doesn't scroll to that element.

I tested using the 1.2 simulator.