920509 - [app manager] don't use hiddenDOMWindow in styles.js

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Description

[Paul Rouget [:paul]]

Changing anything in the rule view has no effect on the page. In the B2G console, we see many "unknown error" messages.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

This seems to specific to the devices.  I can reproduce on my Keon with the Sept. 24th nightly, but it seems to work fine with the 6.0pre2 simulator.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Wild guess: OOP related?

Comment 3

[Paul Rouget [:paul]]

Services.appShell.hiddenDOMWindow is not accessible in /toolkit/devtools/server/actors/styles.js

Comment 4

[Paul Rouget [:paul]]

Attachment: Patch v1

Comment 5

[Paul Rouget [:paul]]

https://tbpl.mozilla.org/?tree=Try&rev=5d1f2612a271

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/a3e2860237a1

Comment 7

[Paul Rouget [:paul]]

Comment on attachment 810583 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: style editor tool doesn't work
Testing completed (on m-c, etc.): fx-team
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a3e2860237a1

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fe28048c6ac0