[MediaRecorder TEST] timeslice test case, error output

RESOLVED FIXED in mozilla33

Status

()

Core
Audio/Video: Recording
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: cjku, Assigned: Shashank VRSN Sabniveesu, Mentored)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=js][good first bug])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
test_mediarecorder_record_timeslice.html  
Line 60: is(mediaRecorder.mimeType, expectedMimeType,  
Line 61: 'Mime type in ondataavailable = ' + expectedMimeType);

Suppose it should be
Line 60: is(mediaRecorder.mimeType, expectedMimeType,  
Line 61: 'Mime type in ondataavailable = ' + mediaRecorder.mimeType);

An easy first bug for new hand to understand check in process and be familiar with how to run mochitest.
(Reporter)

Updated

4 years ago
Blocks: 896935
To fix this, you'll just need to update line 61 to clarify the wording to say:

'Mime type in ondataavailable should be ' + expectedMimeType
Blocks: 889772
No longer blocks: 896935
Whiteboard: [mentor=jsmith][lang=js][good first bug]
(Reporter)

Updated

4 years ago
Assignee: nobody → vichen
Component: Video/Audio → Video/Audio: Recording
Blocks: 1003637
(Reporter)

Updated

4 years ago
Assignee: vichen → nobody
Mentor: jsmith@mozilla.com
Whiteboard: [mentor=jsmith][lang=js][good first bug] → [lang=js][good first bug]
It's a good one to learn how to use the mochitest.
Mentor: jsmith@mozilla.com → rlin@mozilla.com
(Assignee)

Comment 3

3 years ago
Created attachment 8445636 [details] [diff] [review]
BUG 920543 - Correct the 'Mime type in ondataavailable' test case r=rlin
Attachment #8445636 - Flags: review?(rlin)
Comment on attachment 8445636 [details] [diff] [review]
BUG 920543 - Correct the 'Mime type in ondataavailable' test case r=rlin

Review of attachment 8445636 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks a lot. :) r=me, also provide the try result, then you can set check-in needed.
Attachment #8445636 - Flags: review?(rlin) → review+
(Assignee)

Comment 5

3 years ago
Thank you!

Can you suggest the TRY string? I can't find any component by name 'Core' (and don't want to waste resources!) at http://trychooser.pub.build.mozilla.org/
(Assignee)

Updated

3 years ago
Flags: needinfo?(rlin)
Hi Shashank, 
We usually use the "try: -b do -p all -u all -t none" for the final patch.
Flags: needinfo?(rlin)
(Assignee)

Comment 7

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=1a86817cdea4
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0359665c820
Assignee: nobody → shashank
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f0359665c820
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.