Closed Bug 920543 Opened 8 years ago Closed 7 years ago

[MediaRecorder TEST] timeslice test case, error output

Categories

(Core :: Audio/Video: Recording, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: u459114, Assigned: shashank, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [lang=js][good first bug])

Attachments

(1 file)

test_mediarecorder_record_timeslice.html  
Line 60: is(mediaRecorder.mimeType, expectedMimeType,  
Line 61: 'Mime type in ondataavailable = ' + expectedMimeType);

Suppose it should be
Line 60: is(mediaRecorder.mimeType, expectedMimeType,  
Line 61: 'Mime type in ondataavailable = ' + mediaRecorder.mimeType);

An easy first bug for new hand to understand check in process and be familiar with how to run mochitest.
To fix this, you'll just need to update line 61 to clarify the wording to say:

'Mime type in ondataavailable should be ' + expectedMimeType
Blocks: 889772
No longer blocks: MediaRecording
Whiteboard: [mentor=jsmith][lang=js][good first bug]
Assignee: nobody → vichen
Component: Video/Audio → Video/Audio: Recording
Assignee: vichen → nobody
Mentor: jsmith
Whiteboard: [mentor=jsmith][lang=js][good first bug] → [lang=js][good first bug]
It's a good one to learn how to use the mochitest.
Mentor: jsmith → rlin
Comment on attachment 8445636 [details] [diff] [review]
BUG 920543 - Correct the 'Mime type in ondataavailable' test case r=rlin

Review of attachment 8445636 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks a lot. :) r=me, also provide the try result, then you can set check-in needed.
Attachment #8445636 - Flags: review?(rlin) → review+
Thank you!

Can you suggest the TRY string? I can't find any component by name 'Core' (and don't want to waste resources!) at http://trychooser.pub.build.mozilla.org/
Flags: needinfo?(rlin)
Hi Shashank, 
We usually use the "try: -b do -p all -u all -t none" for the final patch.
Flags: needinfo?(rlin)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f0359665c820
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.