Closed
Bug 920543
Opened 12 years ago
Closed 11 years ago
[MediaRecorder TEST] timeslice test case, error output
Categories
(Core :: Audio/Video: Recording, defect)
Core
Audio/Video: Recording
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: u459114, Assigned: shashank, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=js][good first bug])
Attachments
(1 file)
1.25 KB,
patch
|
rlin
:
review+
|
Details | Diff | Splinter Review |
test_mediarecorder_record_timeslice.html
Line 60: is(mediaRecorder.mimeType, expectedMimeType,
Line 61: 'Mime type in ondataavailable = ' + expectedMimeType);
Suppose it should be
Line 60: is(mediaRecorder.mimeType, expectedMimeType,
Line 61: 'Mime type in ondataavailable = ' + mediaRecorder.mimeType);
An easy first bug for new hand to understand check in process and be familiar with how to run mochitest.
Blocks: MediaRecording
Comment 1•12 years ago
|
||
To fix this, you'll just need to update line 61 to clarify the wording to say:
'Mime type in ondataavailable should be ' + expectedMimeType
Whiteboard: [mentor=jsmith][lang=js][good first bug]
Updated•11 years ago
|
Component: Video/Audio → Video/Audio: Recording
Updated•11 years ago
|
Mentor: jsmith
Whiteboard: [mentor=jsmith][lang=js][good first bug] → [lang=js][good first bug]
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8445636 -
Flags: review?(rlin)
Comment 4•11 years ago
|
||
Comment on attachment 8445636 [details] [diff] [review]
BUG 920543 - Correct the 'Mime type in ondataavailable' test case r=rlin
Review of attachment 8445636 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks a lot. :) r=me, also provide the try result, then you can set check-in needed.
Attachment #8445636 -
Flags: review?(rlin) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Thank you!
Can you suggest the TRY string? I can't find any component by name 'Core' (and don't want to waste resources!) at http://trychooser.pub.build.mozilla.org/
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(rlin)
Comment 6•11 years ago
|
||
Hi Shashank,
We usually use the "try: -b do -p all -u all -t none" for the final patch.
Flags: needinfo?(rlin)
Assignee | ||
Comment 7•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 8•11 years ago
|
||
Assignee: nobody → shashank
Keywords: checkin-needed
Comment 9•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•