920585 - update tbpl names for android tests

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

We have standardized on the tests to run, now lets fix tbpl.  Here is what the mappings need to be:
remote-tsvgx: 's'
remote-tspaint: 'ts'
remote-tcanvasmark: 'c'

If these need to map to some other letters, I am fine with that.  These are just good suggestions which I have provided.

Comment 1

[Ed Morley [:emorley]]

https://tbpl-dev.allizom.org/?debug=1

13:17:38.783 "Unknown job! Buildername: Android 4.0 Panda mozilla-central talos remote-tspaint, OS: android-4-0 (Displayed as: Android 4.0), Type: null (Symbol: undefined)" Data.js:616
13:17:38.783 "Unknown job! Buildername: Android 2.2 Tegra mozilla-central talos remote-tspaint, OS: android-2-2 (Displayed as: Android 2.2), Type: null (Symbol: undefined)" Data.js:616
13:17:38.785 "Unknown job! Buildername: Android 2.2 Tegra mozilla-central talos remote-tcanvasmark, OS: android-2-2 (Displayed as: Android 2.2), Type: null (Symbol: undefined)" Data.js:616
13:17:38.785 "Unknown job! Buildername: Android 2.2 Tegra mozilla-central talos remote-tsvgx, OS: android-2-2 (Displayed as: Android 2.2), Type: null (Symbol: undefined)" Data.js:616
13:17:38.787 "Unknown job! Buildername: Android 4.0 Panda mozilla-central talos remote-tsvgx, OS: android-4-0 (Displayed as: Android 4.0), Type: null (Symbol: undefined)" Data.js:616
13:17:38.794 "Unknown job! Buildername: Android 4.0 Panda mozilla-central talos remote-tcanvasmark, OS: android-4-0 (Displayed as: Android 4.0), Type: null (Symbol: undefined)" Data.js:616

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: patch

Using 'cm' for canvasmark ('c' is already in use for chromez), 's' for tsvgx, and 'ts' for tspaint. We only stopped running the old ts suite on Android last week, but consensus with jmaher in #ateam is that a generic T on old runs will suffice since anyone looking at old results is probably looking at datazilla anyway.

Looks OK when run locally and debug=1 doesn't show any issues.

Comment 3

[Ed Morley [:emorley]]

Comment on attachment 810601 [details] [diff] [review]
patch

Review of attachment 810601 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with change below :-)

::: js/Data.js
@@ +524,5 @@
>          /talos dirtypaint$/i.test(name) ? "Talos paint" :
>          /talos remote-troboprovider$/i.test(name) ? "Talos roboprovider" :
>          /talos remote-trobocheck2$/i.test(name) ? "Talos robocheck2" :
>          /talos remote-trobopan$/i.test(name) ? "Talos robopan" :
> +        /talos (?:remote-t)?svg[r|x]?$/i.test(name) ? "Talos svg" :

You just need [rx] - the braces mean "pick any character from here", so the above actually meant "any or 'r', '|' or 'x'" :-)

Comment 4

[Ed Morley [:emorley]]

s/any or/any of/

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Attachment: patch v2

Ended up having to restore support for ts since beta/release still run it. I changed tspaint to 'tsp' instead.

This shows no errors with debug=1 when going through all the trees/project branches and I see no extra 'T' symbols floating around.

https://hg.mozilla.org/webtools/tbpl/rev/db141d6ffd35

Comment 6

[Ed Morley [:emorley]]

In production