Closed Bug 920589 Opened 7 years ago Closed 7 years ago

Only show TabsToolbar gradient in classic themes

Categories

(Firefox :: Theme, defect)

x86_64
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Whiteboard: [Australis:M9][Australis:P1])

Attachments

(1 file)

We have this vertical gradient spanning the entire background of the tabstrip in Windows XP when using Luna (blue, silver, olive).

I think this is slowing us down. The gradient is (arguably) useful in classic themes where the titlebar gets a horizontal gradient from the system, and so the vertical gradient helps to make background tab labels easier to read.

But not for Luna. The gradient there is just silly.

And, handily enough, preliminary testing shows that removing this gradient gives us TART wins across the board for at least Windows XP.
Cc'ing people who might be interested in this bug.
Attached patch Patch v1Splinter Review
This patch makes it so that the gradient is only ever visible when using classic themes.
Attachment #809954 - Flags: review+
I didn't expect an r+ so fast. :) I'll just land this then, and we'll see what wins we get. Try pushes cancelled.
Landed on UX as https://hg.mozilla.org/projects/ux/rev/bd0548b83afc
Whiteboard: [Australis:M?][Australis:P1] → [Australis:M9][Australis:P1][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/bd0548b83afc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M9][Australis:P1][fixed-in-ux] → [Australis:M9][Australis:P1]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.