920641 - fennec-copy-code script does not rm deleted files

Status: RESOLVED WONTFIX

(Android Background Services Graveyard :: Build & Test, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This can cause dead code to be unintentionally left around in the repo.

The script should probably:
  * Find the files that have been rm'd via `git diff`
  * Run `hg diff` on the destination directory to see if there are any changes to the rm'd files
  * If there are not, `hg rm` the files
  * If there are, warn the user about these files

Comment 1

[Richard Newman [:rnewman]]

Or just delete the destination trees before running the copy script.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

> Or just delete the destination trees before running the copy script.

A caveat being if the user changes any code within the destination tree (perhaps accidentally working in both m-c and the services repo?), it'll be overwritten.

But yes, this is much simpler to implement.

Comment 3

[Nick Alexander :nalexander [he/him]]

This is no longer relevant, now that the android-sync repository is dead.