920654 - Enable plane alpha support for HWC layers in newer H/W Composer.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P2)

Description

[Sushil]

Attachment: Enable plane alpha support for HWC layers in newer H/W Composer.

Enable plane alpha support for HWC layers in newer H/W Composer version.

Comment 1

[Michael Wu [:mwu]]

Comment on attachment 810028 [details] [diff] [review]
Enable plane alpha support for HWC layers in newer H/W Composer.

Review of attachment 810028 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/gonk/HwcComposer2D.cpp
@@ +269,4 @@
>  
>      hwcLayer.acquireFenceFd = -1;
>      hwcLayer.releaseFenceFd = -1;
> +    hwcLayer.planeAlpha = (uint8_t)(opacity * 255.0);

I think this conversion is biased a bit towards zero. Something like min(255, opacity*256.0) will give us a better distribution. We should probably use this uint8 value of opacity to determine whether the layer is opaque or not, since it won't give up on values very very close to but not quite 1.0.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 810028 [details] [diff] [review]
Enable plane alpha support for HWC layers in newer H/W Composer.

Waiting for a new patch.

Comment 3

[Sushil]

Attachment: Enable plane alpha support for HWC layers in newer H/W Composer.

Makes sense. Addressed the comments in latest patch.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 813819 [details] [diff] [review]
Enable plane alpha support for HWC layers in newer H/W Composer.

Review of attachment 813819 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/gonk/HwcComposer2D.cpp
@@ +158,3 @@
>      }
>  
>      float opacity = aLayer->GetEffectiveOpacity();

Can you move the float -> int conversion here, and have the rest of the function operate on the int version of opacity?

Comment 5

[Sushil]

Attachment: Enable plane alpha support for HWC layers in newer H/W Composer.

Comment 6

[Sushil]

Diego, could you please check it on ICS device.

Comment 7

[Sushil]

Attachment: Bug 920654 - Enable plane alpha support for HWC layers in newer H/W Composer. r=mwu

Uploading HG friendly patch.

Comment 8

[Diego Wilson [:diego]]

Comment on attachment 817490 [details] [diff] [review]
Bug 920654 - Enable plane alpha support for HWC layers in newer H/W Composer. r=mwu

Review of attachment 817490 [details] [diff] [review]:
-----------------------------------------------------------------

Verified on ICS target

Comment 9

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/integration/b2g-inbound/rev/c92ba82eb054

Comment 10

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/mozilla-central/rev/c92ba82eb054