920681 - Remove the cellspacing and cellpadding attributes from tables

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Frédéric Buclin]

To be HTML5 compliant, the cellspacing attribute must be replaced by its border-spacing CSS-equivalent, and cellpadding must be replaced by padding.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

This patch removes all instances of cellpadding and cellspacing except in email/bugmail.html.tmpl as this template is used for bugmails and I'm not sure how well CSS equivalent rules are understood by email clients.

While fixing attributes of tables, I also did some (related) cleanup:
- Remove useless tables and replace them by <div>. For instance, global/header.html.tmpl no longer uses tables. There are also several error or confirmation messages which didn't need a table and have been replaced by <div>.
- Fix the indentation. In some cases, templates were hard to parse because of incorrect indentation. One example is release notes.
- Remove dead/old code, especially in bug/create/create-guided.html.tmpl (I removed bmo-specific hacks while cleaning up the table).

This makes the patch a bit large, but I think these cleanups were needed. Sorry.

Comment 2

[Dave Miller [:justdave]]

Comment on attachment 8354692 [details] [diff] [review]
patch, v1

works for me, looks much cleaner.

I wasn't really sure about removing the bmo-specific stuff from the guided template, but as far as examples go, bmo's source is available separately now (wasn't always the case in the past) if someone really wants to see how they do it :)

Comment 3

[Frédéric Buclin]

Thanks a lot justdave for this huge review. :)

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified describekeywords.cgi
modified skins/standard/admin.css
modified skins/standard/attachment.css
modified skins/standard/buglist.css
modified skins/standard/enter_bug.css
modified skins/standard/global.css
modified skins/standard/params.css
modified skins/standard/reports.css
modified skins/standard/summarize-time.css
modified template/en/default/filterexceptions.pl
modified template/en/default/account/prefs/email.html.tmpl
modified template/en/default/account/prefs/saved-searches.html.tmpl
modified template/en/default/account/prefs/settings.html.tmpl
modified template/en/default/admin/confirm-action.html.tmpl
modified template/en/default/admin/classifications/add.html.tmpl
modified template/en/default/admin/classifications/del.html.tmpl
modified template/en/default/admin/classifications/edit.html.tmpl
modified template/en/default/admin/classifications/reclassify.html.tmpl
modified template/en/default/admin/classifications/select.html.tmpl
modified template/en/default/admin/components/confirm-delete.html.tmpl
modified template/en/default/admin/components/create.html.tmpl
modified template/en/default/admin/components/edit-common.html.tmpl
modified template/en/default/admin/components/edit.html.tmpl
modified template/en/default/admin/custom_fields/confirm-delete.html.tmpl
modified template/en/default/admin/custom_fields/edit-common.html.tmpl
modified template/en/default/admin/fieldvalues/confirm-delete.html.tmpl
modified template/en/default/admin/fieldvalues/create.html.tmpl
modified template/en/default/admin/fieldvalues/edit.html.tmpl
modified template/en/default/admin/flag-type/edit.html.tmpl
modified template/en/default/admin/flag-type/list.html.tmpl
modified template/en/default/admin/groups/create.html.tmpl
modified template/en/default/admin/groups/delete.html.tmpl
modified template/en/default/admin/groups/edit.html.tmpl
modified template/en/default/admin/keywords/confirm-delete.html.tmpl
modified template/en/default/admin/keywords/create.html.tmpl
modified template/en/default/admin/keywords/edit.html.tmpl
modified template/en/default/admin/milestones/confirm-delete.html.tmpl
modified template/en/default/admin/milestones/create.html.tmpl
modified template/en/default/admin/milestones/edit.html.tmpl
modified template/en/default/admin/params/editparams.html.tmpl
modified template/en/default/admin/products/confirm-delete.html.tmpl
modified template/en/default/admin/products/create.html.tmpl
modified template/en/default/admin/products/edit.html.tmpl
modified template/en/default/admin/products/groupcontrol/edit.html.tmpl
modified template/en/default/admin/settings/edit.html.tmpl
modified template/en/default/admin/users/responsibilities.html.tmpl
modified template/en/default/admin/versions/confirm-delete.html.tmpl
modified template/en/default/admin/versions/create.html.tmpl
modified template/en/default/admin/versions/edit.html.tmpl
modified template/en/default/attachment/confirm-delete.html.tmpl
modified template/en/default/attachment/diff-file.html.tmpl
modified template/en/default/attachment/list.html.tmpl
modified template/en/default/bug/comments.html.tmpl
modified template/en/default/bug/edit.html.tmpl
modified template/en/default/bug/summarize-time.html.tmpl
modified template/en/default/bug/activity/table.html.tmpl
modified template/en/default/bug/create/create-guided.html.tmpl
modified template/en/default/bug/process/verify-new-product.html.tmpl
modified template/en/default/global/code-error.html.tmpl
modified template/en/default/global/confirm-user-match.html.tmpl
modified template/en/default/global/footer.html.tmpl
modified template/en/default/global/header.html.tmpl
modified template/en/default/global/tabs.html.tmpl
modified template/en/default/global/user-error.html.tmpl
modified template/en/default/list/edit-multiple.html.tmpl
modified template/en/default/list/list.html.tmpl
modified template/en/default/list/quips.html.tmpl
modified template/en/default/list/table.html.tmpl
modified template/en/default/pages/quicksearch.html.tmpl
modified template/en/default/pages/release-notes.html.tmpl
modified template/en/default/pages/release-notes3.html.tmpl
modified template/en/default/reports/components.html.tmpl
modified template/en/default/reports/duplicates-table.html.tmpl
modified template/en/default/reports/keywords.html.tmpl
modified template/en/default/reports/old-charts.html.tmpl
modified template/en/default/reports/report-table.html.tmpl
modified template/en/default/request/queue.html.tmpl
modified template/en/default/search/search-specific.html.tmpl
Committed revision 8842.