920682 - [music] Use a smarter method to notify IAC subscribers when the music app closes

Status: RESOLVED DUPLICATE of bug 1215674

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Jim Porter (:squib)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/12452

Over in bug 915880, Gene and I discussed some alternatives to the current method I use to hide the "now playing" notification in the system app. It turns out we can just post a message in the "unload" event listener in the music app, and all is well. Therefore, let's do that and remove an ugly workaround!

Comment 1

[Jim Porter (:squib)]

Comment on attachment 810061 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/12452

Cancelling review for now since this doesn't work right when the OOM killer kills the music app. I'm going to write some tests and see if I can improve things here.

Comment 2

[Jim Porter (:squib)]

I'm going to leave this bug open to track the changes we should make if/when bug 915880 is fixed. Hopefully we'll come up with an acceptable solution over there, since not being able to know when an IAC connection is terminated is extremely inconvenient.

Comment 3

[Jim Porter (:squib)]

Closing this, since we'll be moving to the Media Controller API someday (hopefully soon).

Comment 4

[Jim Porter (:squib)]

Actually, I think I was right to close this, since the change wouldn't happen in the Music app, and we have other bugs to track the changes elsewhere.