920695 - Link xpcshell functionality into libxul, make xpcshell.exe a little stub

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Benjamin Smedberg]

In order to stop exporting JS symbols, we need to have a solution for xpcshell, and the simplest solution is just to build xpcshell into libxul and export it. Mine!

Comment 1

[Benjamin Smedberg]

Attachment: part A - move xpcshell code into libxul and make the xpcshell binary just a stub, r?bholley

Comment 2

[Benjamin Smedberg]

Attachment: part B - Remove references to JS_READLINE/EDITLINE since its in a different place now and won't work, r?bholley

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 810127 [details] [diff] [review]
part A - move xpcshell code into libxul and make the xpcshell binary just a stub, r?bholley

Review of attachment 810127 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't read through the cut-paste here. If there are any significant changes in there that you want me to review, please upload some kind of reduced diff.

r=bholley with comments addressed.

::: js/xpconnect/shell/xpcshell.cpp
@@ +30,3 @@
>  {
>  #ifdef XP_MACOSX
> +  InitAutoreleasePool();

XPConnect uses 4-space indentation. I don't care a huge about for this stub file, but we should probably be consistent.

::: js/xpconnect/src/moz.build
@@ +49,5 @@
>      'nsCxPusher.cpp',
>      'nsScriptError.cpp',
>      'nsXPConnect.cpp',
>      'Sandbox.cpp',
> +    'shellimpl.cpp',

Let's call this XPCShellImpl.cpp.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 810130 [details] [diff] [review]
part B - Remove references to JS_READLINE/EDITLINE since its in a different place now and won't work, r?bholley

Review of attachment 810130 [details] [diff] [review]:
-----------------------------------------------------------------

Hopefully nobody's using this. r=holley

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9e6846fd74a2
https://hg.mozilla.org/mozilla-central/rev/e403b2561ceb