9207 - Click on toplevel menu in plaintext editor causes crash

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Akkana Peck]

In the plaintext editor window (brought up from the editor window with
Tools->New Plaintext Editor), clicking on any toplevel menu button causes a
crash:


#0  0x40a69223 in RDFElementImpl::SetAttribute (this=0x83f0de0,
    aName=@0xbfffe380, aValue=@0xbfffe39c)
    at /builds/fri/mozilla/rdf/content/src/nsRDFElement.cpp:915
#1  0x40211cc3 in nsMenu::MenuConstruct (this=0x84987b8,
    aMenuEvent=@0xbfffe3e8, aParentWindow=0x0, menuNode=0x0,
    aWebShell=0x83a07e8) at
/builds/fri/mozilla/widget/src/gtk/nsMenu.cpp:508

Comment 1

[Akkana Peck]

Reverting TextEditorAppShell.xul to cmanske's version 1.4 doesn't help, still
crashes.  Reverting to version 1.3 not only solves the menu problem but also
solves the problem of not being able to click in the window.

I'm going to check that in for the time being; Hyatt and Charley can fight over
the right fix that doesn't completely hork the window.

Comment 2

[Simon Fraser [no longer active]]

TextEditorAppShell.xul was messed up, having type="content" instead of
type="content-primary", and it also contained C++ style comments. I fixed
those. But we still shouldn't crash with bad XUL.

Comment 3

[David Hyatt]

So is this fixed?

Comment 4

[David Hyatt]

In the absence of any comments (and because I'm completely doomed regarding my
M8 bugs), I'm marking this fixed.

Comment 5

[Akkana Peck]

The crash is fixed, but what about sfraser's comment that it still shouldn't
crash with bad XUL?

Reopening, but marking M9 (doesn't have to be M8 since we have a workaround).

Comment 6

[David Hyatt]

I already have a bug about that.

Comment 7

[phillip]

verified on

     1999-07-13-08 RedHat Linux 5.2 kernel 2.2.9
     1999-07-13-10 WinNT 4.0 sp4
     1999-07-13-09 MacOS 8.51