920746 - [commbadge] replace App History section with commbadge API response for the app's threads

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[Christopher Van Wiemeersch [:cvan]]

Replace http://f.cl.ly/items/0U472b2c1K1r1e1d0k0H/Screen%20Shot%202013-09-25%20at%2010.33.34%20AM.png with a list of the notes from the commbadge API. Please do an XHR to fetch all the threads for the app. (Please note that if the user isn't logged into commbadge, there will be no shared-secret user token - so take that into account.)

Comment 1

[Davor Spasovski [:spasovski]]

Kevin, any thoughts?

Comment 2

[Kevin Ngo [:ngoke]]

Depends on migrating ActivityLog objects to CommunicationNote objects. But a good direction to go towards.

Comment 3

[Kevin Ngo [:ngoke]]

I won't be able to take this bug for a while though, busy with other bugs.

Comment 6

[Kevin Ngo [:ngoke]]

Under a waffle: https://github.com/mozilla/zamboni/pull/1784

Comment 7

[Kevin Ngo [:ngoke]]

Not going to run the migration of old notes so a lot of review pages on -dev will be empty.

Comment 8

[Andrew Williamson [:eviljeff]]

(In reply to Kevin Ngo [:ngoke] from comment #7)
> Not going to run the migration of old notes so a lot of review pages on -dev
> will be empty.

Doesn't https://bugzilla.mozilla.org/show_bug.cgi?id=920743 do the migration?

Comment 9

[Victor Carciu]

Can you please add some specific STRs to this bug or mark it as [qa-] ?

Comment 10

[Kevin Ngo [:ngoke]]

Yeah, https://bugzilla.mozilla.org/show_bug.cgi?id=920743 is the migration. I'll run it today on -dev.

STR:

1. As a reviewer, post a note for some app on Commbadge.
2. Go to review page of that app.
3. Scroll to app history section.

Expected:

Note is visible.

Actual:

Notes made from Commbadge are not visible from Reviewer Tools.

Comment 11

[Victor Carciu]

Verified as fixed : http://screencast.com/t/rjVcOiG64me

Comment 12

[jannatulferdousborna13]

I have tried to test this bug.

Comment 13

[jannatulferdousborna13]

I have tried to test this bug. version 38.0a2(2015-03-19)