Closed Bug 920750 Opened 8 years ago Closed 6 years ago

Disable update xml certificate checks on Mac OS X

Categories

(Firefox :: Preferences, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file, 1 obsolete file)

When there are signed mar checks across all major platforms (bug 903126) we should disable via preference the certificate attribute checks and the certificate built-in check. I've discussed this with dveditz and he is ok with this.
Depends on: 903126
We already have signed mar checks on Windows so I filed bug 928489 to get the checks removed only on Windows and this bug will be for the remaining platforms after bug 903126 is fixed.
OS: Windows 7 → Mac OS X
Summary: Disabled certificate checks for the update xml check → Disabled certificate checks on platforms other than Windows for the update xml check
Bug 928489 is the new bug for Windows only
No longer blocks: 928489
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #819153 - Flags: review?(netzen)
Comment on attachment 819153 [details] [diff] [review]
Patch - disable app update xml cert checks on Windows

Missed a change
Attachment #819153 - Attachment is obsolete: true
Attachment #819153 - Flags: review?(netzen)
Yep looks like we default to true:
http://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/nsUpdateService.js#l3682

Also could you include metro.js with the same change?
Already done
Summary: Disabled certificate checks on platforms other than Windows for the update xml check → Disable update xml certificate checks on platforms other than Windows
It's unlikely that I will get to work on this in the next two weeks, so unassigning myself for now.
Assignee: robert.strong.bugs → nobody
Summary: Disable update xml certificate checks on platforms other than Windows → Disable update xml certificate checks on Mac OS X
Attached patch patchSplinter Review
Assignee: nobody → robert.strong.bugs
Attachment #8588622 - Flags: review?(netzen)
Comment on attachment 8588622 [details] [diff] [review]
patch

Review of attachment 8588622 [details] [diff] [review]:
-----------------------------------------------------------------

Just make sure the landing sticks for mar verification before landing pls.
Attachment #8588622 - Flags: review?(netzen) → review+
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/816465912339
Target Milestone: --- → Firefox 40
This (and the other two patches in that push) is backed out in https://hg.mozilla.org/integration/fx-team/rev/5e86f11941da for windows xpcshell updater test failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=2596450&repo=fx-team
Flags: needinfo?(robert.strong.bugs)
This is not the patch that caused the oranges. I'll re-land in a little while.
https://hg.mozilla.org/mozilla-central/rev/f87c7a84a77f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.