920800 - Add openKeyCursor to IDBObjectStore

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

At the Google meetup a while back we all agreed that openKeyCursor should exist on IDBObjectStore as well as IDBIndex.

Requires bug 920179 in order for the tests to work.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

There are a bunch of s/NS_ASSERTION/MOZ_ASSERT/ changes in here but I tried to only touch the ones where I actually needed to change the method. Hopefully it's not too noisy.

Comment 2

[Jan Varga [:janv]]

Comment on attachment 810192 [details] [diff] [review]
Patch, v1

Review of attachment 810192 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

::: dom/indexedDB/test/unit/test_objectStore_openKeyCursor.js
@@ +264,5 @@
> +    }
> +  }
> +  ok(match, "All keys matched");
> +
> +

Nit: extra empty line ?

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb0041643a0f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out because this depends on bug 920179 which had to be backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/19b202186812

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87a72129c007

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And out again: http://hg.mozilla.org/integration/mozilla-inbound/rev/a11f8859f7d8

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8aca6978ed9 should work.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8aca6978ed9

Comment 9

[Jean-Yves Perrier [:teoli]]

Doc up-to-date:
https://developer.mozilla.org/en-US/Firefox/Releases/27#Interfaces.2FAPIs.2FDOM
and
https://developer.mozilla.org/en-US/docs/Web/API/IDBObjectStore.openKeyCursor