Closed Bug 920800 Opened 6 years ago Closed 6 years ago

Add openKeyCursor to IDBObjectStore

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Attached patch Patch, v1Splinter Review
At the Google meetup a while back we all agreed that openKeyCursor should exist on IDBObjectStore as well as IDBIndex.

Requires bug 920179 in order for the tests to work.
Attachment #810192 - Flags: review?(Jan.Varga)
There are a bunch of s/NS_ASSERTION/MOZ_ASSERT/ changes in here but I tried to only touch the ones where I actually needed to change the method. Hopefully it's not too noisy.
Comment on attachment 810192 [details] [diff] [review]
Patch, v1

Review of attachment 810192 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

::: dom/indexedDB/test/unit/test_objectStore_openKeyCursor.js
@@ +264,5 @@
> +    }
> +  }
> +  ok(match, "All keys matched");
> +
> +

Nit: extra empty line ?
Attachment #810192 - Flags: review?(Jan.Varga) → review+
Backed out because this depends on bug 920179 which had to be backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/19b202186812
https://hg.mozilla.org/mozilla-central/rev/a8aca6978ed9
Assignee: nobody → bent.mozilla
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.