Closed Bug 920840 Opened 6 years ago Closed 6 years ago
Crash when JS implemented Web
IDL init() returns a value other than undefined
Right now it seems like we MOZ_ASSERT() (https://bugzil.la/884897#c11), but bug 920831 and future uses especially those not having tests are likely to make the same mistakes Push did.
Assignee: nobody → continuation
OS: Linux → All
Hardware: x86_64 → All
Yes, doing this as a followup for bug 884897 was in my backlog, but I hadn't gotten to it. :(
Oh, and: > especially those not having tests No comment.
I updated the WebIDL bindings documentation for JS-implemented WebIDL to talk about the init() issue, and how to properly implement pref and permission checks.
Comment on attachment 810867 [details] [diff] [review] I like to crash it crash it Try run is green, for whatever that's worth: https://tbpl.mozilla.org/?tree=Try&rev=5186c4a24031
Attachment #810867 - Flags: review?(bzbarsky)
Comment on attachment 810867 [details] [diff] [review] I like to crash it crash it r=me
Attachment #810867 - Flags: review?(bzbarsky) → review+
We should probably get this on Aurora or whatever B2GNext is using. https://hg.mozilla.org/integration/mozilla-inbound/rev/6d0b41d53c32
Backed out for B2G mochitest-3 perma-fail. https://hg.mozilla.org/integration/mozilla-inbound/rev/2106260cb59b https://tbpl.mozilla.org/php/getParsedLog.php?id=28480685&tree=Mozilla-Inbound
RyanVM points out that that's the same failure I saw on the try run. I guess my eyes are too tuned in to look for orange and not red...
Oops, looks like I just need to wait for bug 920831 to land: https://tbpl.mozilla.org/?tree=Try&rev=675001f2451a
Bug 920831 needs some unbitrotting first. Backed out. https://hg.mozilla.org/integration/b2g-inbound/rev/ed1bed4fbaab
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.