Closed Bug 920840 Opened 6 years ago Closed 6 years ago

Crash when JS implemented WebIDL init() returns a value other than undefined

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: nsm, Assigned: mccr8)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Right now it seems like we MOZ_ASSERT() (https://bugzil.la/884897#c11), but bug 920831 and future uses especially those not having tests are likely to make the same mistakes Push did.
Assignee: nobody → continuation
OS: Linux → All
Hardware: x86_64 → All
Yes, doing this as a followup for bug 884897 was in my backlog, but I hadn't gotten to it.  :(
Oh, and:

> especially those not having tests 

No comment.
I updated the WebIDL bindings documentation for JS-implemented WebIDL to talk about the init() issue, and how to properly implement pref and permission checks.
Comment on attachment 810867 [details] [diff] [review]
I like to crash it crash it

Try run is green, for whatever that's worth: https://tbpl.mozilla.org/?tree=Try&rev=5186c4a24031
Attachment #810867 - Flags: review?(bzbarsky)
Comment on attachment 810867 [details] [diff] [review]
I like to crash it crash it

r=me
Attachment #810867 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
We should probably get this on Aurora or whatever B2GNext is using.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d0b41d53c32
Keywords: checkin-needed
RyanVM points out that that's the same failure I saw on the try run.  I guess my eyes are too tuned in to look for orange and not red...
Oops, looks like I just need to wait for bug 920831 to land: https://tbpl.mozilla.org/?tree=Try&rev=675001f2451a
Depends on: 920831
Keywords: checkin-needed
Blocks: 922334
No longer blocks: 922334
https://hg.mozilla.org/mozilla-central/rev/133d0dee12ee
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.