920840 - Crash when JS implemented WebIDL init() returns a value other than undefined

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Right now it seems like we MOZ_ASSERT() (https://bugzil.la/884897#c11), but bug 920831 and future uses especially those not having tests are likely to make the same mistakes Push did.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Yes, doing this as a followup for bug 884897 was in my backlog, but I hadn't gotten to it.  :(

Comment 2

[Boris Zbarsky [:bzbarsky]]

Oh, and:

> especially those not having tests 

No comment.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: I like to crash it crash it

Comment 4

[Andrew McCreight [:mccr8]]

I updated the WebIDL bindings documentation for JS-implemented WebIDL to talk about the init() issue, and how to properly implement pref and permission checks.

Comment 5

[Andrew McCreight [:mccr8]]

Comment on attachment 810867 [details] [diff] [review]
I like to crash it crash it

Try run is green, for whatever that's worth: https://tbpl.mozilla.org/?tree=Try&rev=5186c4a24031

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 810867 [details] [diff] [review]
I like to crash it crash it

r=me

Comment 7

[Andrew McCreight [:mccr8]]

We should probably get this on Aurora or whatever B2GNext is using.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d0b41d53c32

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for B2G mochitest-3 perma-fail.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2106260cb59b

https://tbpl.mozilla.org/php/getParsedLog.php?id=28480685&tree=Mozilla-Inbound

Comment 9

[Andrew McCreight [:mccr8]]

RyanVM points out that that's the same failure I saw on the try run.  I guess my eyes are too tuned in to look for orange and not red...

Comment 10

[Andrew McCreight [:mccr8]]

Oops, looks like I just need to wait for bug 920831 to land: https://tbpl.mozilla.org/?tree=Try&rev=675001f2451a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/dac111df7fdf

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Bug 920831 needs some unbitrotting first. Backed out.
https://hg.mozilla.org/integration/b2g-inbound/rev/ed1bed4fbaab

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/133d0dee12ee

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/133d0dee12ee