920852 - Rename class fields to match memory reporter paths.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

When measuring various things in the JS engine, we try to keep the field names
the same as the paths used in the memory reporters.  Some time recently the 
paths got rearranged without the field names being changed.  This bug will fix
that.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) Rename fields of ObjectsExtraSizes and CompartmentStats to match memory reporter paths.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Rename fields of ZoneStatsPod and StringInfo to match memory reporter paths.

As well as renaming the fields, I fixed a couple of minor errors in paths.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Tweak various things about RuntimeStats.

This patch does the following.

- Renames RuntimeStats::gcHeapGcThings.

- Removes RuntimeStats::gcHeapUnusedGcThings -- it's dead.

- Moves the computation of rtStats->gcHeapGCThings and totalArenaSize --
  instead of incrementing them for each compartment and zone, we just compute
  them from the compartment and zone totals.

- Removes a bogus decrement of rtStats->gcHeapUnusedArenas.  This is dead code
  because it's assigned to immediately afterwards.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Reorder a bunch of stuff.

No functional changes here.  I just put various things in a more sensible
order.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Tweak various things about RuntimeStats.

This version fixes a problem -- sizeOfLiveGCThings() was wrong for ZoneStats,
because it didn't count strings that had been marked as notable.  This didn't
show up as a problem before because we only ever called sizeOfLiveGCThings()
before calling FindNotableStrings().

But now that has changed, it needs fixing, which is pretty simple.  Thank
heaven for assertions.

Comment 6

[Till Schneidereit [:till]]

Comment on attachment 810269 [details] [diff] [review]
(part 1) Rename fields of ObjectsExtraSizes and CompartmentStats to match memory reporter paths.

Review of attachment 810269 [details] [diff] [review]:
-----------------------------------------------------------------

The new naming scheme makes a lot of sense to me.

(Also, Splinter is entirely useless for this kind of review. Proper diff tools to the rescue!)

Comment 7

[Till Schneidereit [:till]]

Comment on attachment 810283 [details] [diff] [review]
(part 2) - Rename fields of ZoneStatsPod and StringInfo to match memory reporter paths.

Review of attachment 810283 [details] [diff] [review]:
-----------------------------------------------------------------

I approve

Comment 8

[Till Schneidereit [:till]]

Comment on attachment 810304 [details] [diff] [review]
(part 4) - Reorder a bunch of stuff.

Review of attachment 810304 [details] [diff] [review]:
-----------------------------------------------------------------

nice

Comment 9

[Till Schneidereit [:till]]

Comment on attachment 810346 [details] [diff] [review]
(part 3) - Tweak various things about RuntimeStats.

Review of attachment 810346 [details] [diff] [review]:
-----------------------------------------------------------------

yep

(In this case, though: my kingdom for a content-aware diff tool!)

Comment 10

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66173e4d2735
https://hg.mozilla.org/integration/mozilla-inbound/rev/5337cffcd17d
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f1e4c73c502
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fb1c750791f

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/66173e4d2735
https://hg.mozilla.org/mozilla-central/rev/5337cffcd17d
https://hg.mozilla.org/mozilla-central/rev/0f1e4c73c502
https://hg.mozilla.org/mozilla-central/rev/6fb1c750791f

Comment 12

[John Schoenick [:johns]]

Attachment: [b2g26 folded] Rename class fields to match memory reporter paths. r=till.

--HG--
extra : rebase_source : 0f55dd20e69d3410d0cb811529f53570f588cc5e