Don't pass empty url into mapper.routematch

VERIFIED FIXED

Status

Cloud Services
Server: Core
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: rfkelly, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 810280 [details] [diff] [review]
no-empty-url.patch

This was reported by a user in #sync; when request.path_info is empty our url-matching logic throws an exception.
Attachment #810280 - Flags: review?(telliott)
Attachment #810280 - Flags: review?(telliott) → review+
(Reporter)

Comment 1

4 years ago
http://hg.mozilla.org/services/server-core/rev/4daa9cf904bb
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Is there some QA love needed here or are we good to go?
Whiteboard: [qa+]
(Reporter)

Comment 3

4 years ago
I think we're OK - obscure error case, trivial fix, proper test coverage
Awesome.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.