920915 - --with-app-name No longer works

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Alex Kontos]

Attachment: log

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20100101 Firefox/24.0 (Beta/Release)
Build ID: 20130910160258

Steps to reproduce:

Building in an x64 Windows environment, --with-app-name no longer works. Appears to be a Win64 (not tested on 32) issue. Works with Linux.


Actual results:

Build breaks towards the very end of compilation:
No rule to make target 'TEST.exe.manifest' needed by ['<command-line>', 'TEST.exe.manifest']
evaluation from c:\Users\Alex\Downloads\mozilla-release\config\rules.mk:1794:4:2:0$ rm -f "../../dist/bin/browser/defaults/preferences/firefox.js"
<TEST.exe>: Found error


Expected results:

--with-app-name should set MOZ_APP_DISPLAYNAME to whatever user specifies in mozconfig.

I'm not sure what the exact issue is, has something to do with EXTRA_DEPS += $(PROGRAM).manifest in browser/app/makefile.in.

Comment 1

[Michael Shal [:mshal]]

Attachment: 0001-Bug-920915-Use-correct-manifest-dependencies.patch

This patch fixes it locally. Waiting on some try results to see if I broke anything...

Comment 2

[Michael Shal [:mshal]]

https://tbpl.mozilla.org/?tree=Try&rev=bb490399379f

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 811178 [details] [diff] [review]
0001-Bug-920915-Use-correct-manifest-dependencies.patch

This replaces the $(PROGRAM).manifest dependencies with the explicit filenames, since the .manifest files exist in the tree (they aren't generated by the build system, so they shouldn't use PROGRAM).

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 811178 [details] [diff] [review]
0001-Bug-920915-Use-correct-manifest-dependencies.patch

Review of attachment 811178 [details] [diff] [review]:
-----------------------------------------------------------------

Fun. Can you add a comment stating the filename is static because it's checked in? Otherwise, I could see someone reverting this because we normally don't hardcode "firefox" anywhere.

Comment 5

[Michael Shal [:mshal]]

Attachment: 0001-Bug-920915-Use-correct-manifest-dependencies.patch

Now with comments. r+ carried forward.

Comment 6

[Michael Shal [:mshal]]

inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/adcccc27be85

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/adcccc27be85