When searching in frames, selection is visible in > 1 frame

VERIFIED FIXED in mozilla0.9.4

Status

()

Core
Editor
P3
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: Conrad Carlen (not reading bugmail), Assigned: Conrad Carlen (not reading bugmail))

Tracking

({topembed})

Trunk
mozilla0.9.4
topembed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
1) Go to a site with frames.
2) Search for a word which is found in one frame - it will be hilited.
3) Find next.
4) If the word exists in a subsequent frame, the word is hilited but the word
remains hilited in the previous frame.

The selection should be un-hilited in the previous frame.
(Assignee)

Comment 1

17 years ago
Created attachment 43376 [details] [diff] [review]
patch to turn off previous found selection
(Assignee)

Comment 2

17 years ago
The patch fixes it. If a find was successful and a selection was made, the frame
is remembered. If, next time through, we find in a different frame, the
selection that we set before is cleared. Do we think this is the right behavior?
If so, can I get r=?

Comment 3

17 years ago
putting in 9.4 to get on Simon's radar
Priority: -- → P3
Target Milestone: --- → mozilla0.9.4
(Assignee)

Comment 4

17 years ago
While the patch here fixes it, it's more of a workaround. The find code is
already setting focus on the window in which the find occurred. I think the
focus code, which must un-focus the previously focused window, should collapse
the selection in the unfocused window.

Updated

17 years ago
Keywords: topembed

Comment 5

17 years ago
The patch looks OK to me; it's better to do this in the Find code than the
selection/focus code (there are other bugs about how selection should look on
framed pages).

sr=sfraser on the patch. Conrad, do you want the bug back?
(Assignee)

Comment 6

17 years ago
Sure, I'll take the bug back.
(Assignee)

Comment 7

17 years ago
Jud, can you review this one?
Assignee: sfraser → ccarlen

Comment 8

17 years ago
r=valeski
(Assignee)

Comment 9

17 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 10

17 years ago
Verified on 8-30 build
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.