92100 - When searching in frames, selection is visible in > 1 frame

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Conrad Carlen (not reading bugmail)]

1) Go to a site with frames.
2) Search for a word which is found in one frame - it will be hilited.
3) Find next.
4) If the word exists in a subsequent frame, the word is hilited but the word
remains hilited in the previous frame.

The selection should be un-hilited in the previous frame.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch to turn off previous found selection

Comment 2

[Conrad Carlen (not reading bugmail)]

The patch fixes it. If a find was successful and a selection was made, the frame
is remembered. If, next time through, we find in a different frame, the
selection that we set before is cleared. Do we think this is the right behavior?
If so, can I get r=?

Comment 3

[rubydoo123]

putting in 9.4 to get on Simon's radar

Comment 4

[Conrad Carlen (not reading bugmail)]

While the patch here fixes it, it's more of a workaround. The find code is
already setting focus on the window in which the find occurred. I think the
focus code, which must un-focus the previously focused window, should collapse
the selection in the unfocused window.

Comment 5

[Simon Fraser [no longer active]]

The patch looks OK to me; it's better to do this in the Find code than the
selection/focus code (there are other bugs about how selection should look on
framed pages).

sr=sfraser on the patch. Conrad, do you want the bug back?

Comment 6

[Conrad Carlen (not reading bugmail)]

Sure, I'll take the bug back.

Comment 7

[Conrad Carlen (not reading bugmail)]

Jud, can you review this one?

Comment 8

[Judson Valeski]

r=valeski

Comment 9

[Conrad Carlen (not reading bugmail)]

Fix checked in.

Comment 10

[James Baxter]

Verified on 8-30 build