921033 - Make InterAppMessageEvent to use webidl event codegen

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Patch coming

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

#include "mozilla/dom/MozInterAppMessageEvent.h" is a bit hack since we need
to be able to #include both MozInterAppMessageEvent and InterAppComm
in the binding code so that things compile.

https://tbpl.mozilla.org/?tree=Try&rev=55ac207829a0
At least this compiles locally, but we don't have any tests so this may or may not break stuff.

Comment 2

[Gene Lian (I already quit Mozilla)]

(In reply to Olli Pettay [:smaug] from comment #1)
> Created attachment 810602 [details] [diff] [review]
> patch
> 
> #include "mozilla/dom/MozInterAppMessageEvent.h" is a bit hack since we need
> to be able to #include both MozInterAppMessageEvent and InterAppComm
> in the binding code so that things compile.

This is awesome! Thanks for cleaning it up. Testing your patch.

> 
> https://tbpl.mozilla.org/?tree=Try&rev=55ac207829a0
> At least this compiles locally, but we don't have any tests so this may or
> may not break stuff.

I apologize for not having tests. It's under way working. I'll make it on V1.3.

Comment 3

[Gene Lian (I already quit Mozilla)]

Comment on attachment 810602 [details] [diff] [review]
patch

Review of attachment 810602 [details] [diff] [review]:
-----------------------------------------------------------------

It's working great. Thank you! Please go ahead to land. r=gene

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Thanks for testing!

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/905efeae3ba7

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/905efeae3ba7