Closed Bug 921128 Opened 11 years ago Closed 9 years ago

Regression: Highlight for "Most recent" header on tablet is misaligned

Categories

(Firefox for Android Graveyard :: General, defect)

27 Branch
ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: liuche, Unassigned, Mentored)

References

Details

(Keywords: polish, Whiteboard: [lang=java])

Attachments

(1 file)

Attached image history-list-spacer.png
There's an extra pixel or so of space at the bottom of the "Most recent" header on tablets.
Keywords: polish
Whiteboard: [mentor=lucasr][lang=java]
Hello. I am in my junior year of college, studying computer science and engineering. I would like to work on this bug fix. Is that okay?
Yes, and welcome - I am assigning the bug to you. I am also requesting info from Lucas to assist you in pinpointing the area of code where this bug exists.
Assignee: nobody → ashwinswaroop93
Flags: needinfo?(lucasr.at.mozilla)
Status: NEW → ASSIGNED
(In reply to ashwinswaroop93 from comment #1)
> Hello. I am in my junior year of college, studying computer science and
> engineering. I would like to work on this bug fix. Is that okay?

Sure! The first step is to get Firefox for Android built and running locally. Have a look at these instructions:

https://wiki.mozilla.org/Mobile/Fennec/Android

I recommend you to join our IRC channel #mobile in irc.mozilla.org to get quicker answers from the team. Let us know when you're ready to go.
Flags: needinfo?(lucasr.at.mozilla)
I've actually already finished building Firefox on my computer. I ran a find Unix command and searched for history-list-spacer.png but it didn't seem to exist in the mozilla-central directory. Is there something else I should be doing?
I haven't got any response from anyone here or on IRC. Should I move on to another defect?
Lucas is away for the Holidays, happy to redirect your question over to another front-end dev.
Flags: needinfo?(margaret.leibovic)
Hi ashwinswaroop93, sorry you didn't get a response sooner! history-list-spacer.png is just the name of the image that liuche attached to this bug to show the problem, so that's why it's not in the tree.

I'm actually not familiar with how our about:home tablet UI works, so I'm asking liuche if she knows where to look to fix this problem. 

Doing a quick search, it looks like this file makes the layout for our tablet history page:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout-large-land-v11/home_history_page.xml

So you need to dig into the IconTabWidget styles.
Flags: needinfo?(margaret.leibovic)
Hi ashwinswaroop93, take a look at Margaret's suggestions, and I'll try to provide a little bit of useful context:

The Java code for our about:home code is in $SRC/mobile/android/base/home, and the file of interest is HistoryPage.java. For instance, you can see that the layout for the History page is set in onCreateView:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/HistoryPage.java#30

To find these resources, you'll want to look in $SRC/mobile/android/base/resources. If you notice, there are actually several resources/layout* directories - this is because Android will load resources based on paramters of the device (screensize, orientation, Android version). "large" or "xlarge" describe tablets, so you'll want to look at those.

Those tablet resources will give you an idea of what items are used in the page layouts, and you'll want to look at their styles to find why the divider between the tabs is offset.

Let us know if you have any other questions!
Mentor: lucasr.at.mozilla
Whiteboard: [mentor=lucasr][lang=java] → [lang=java]
Mentor: lucasr.at.mozilla → liuche
Assignee: ashwinswaroop93 → nobody
Also closing this because this design no longer applies.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: