Closed Bug 921222 Opened 11 years ago Closed 11 years ago

Make disabled buttons look disabled

Categories

(DevTools Graveyard :: WebIDE, defect, P1)

Product:
DevTools Graveyard
Component:
WebIDE
Type:
defect

Tracking

(firefox26 verified, firefox27 verified, b2g-v1.2 fixed)

Status:
VERIFIED FIXED
Milestone:
Firefox 27
Tracking Flags:
Tracking Status
firefox26 --- verified
firefox27 --- verified
b2g-v1.2 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(1 file, 1 obsolete file)

Make App Manager disabled buttons look disabled (v2)
2.65 KB, patch
paul
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Currently it's not very clear that disabled buttons are disabled, since they don't change in appearance.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 810799 [details] [diff] [review] Make App Manager disabled buttons look disabled Can you also do that for device.css? Don't use `cursor:not-allowed`. Use `pointer-events:none`.
Attachment #810799 - Flags: review?(poirot.alex)
Made all changes from previous review.
Attachment #810799 - Attachment is obsolete: true
Attachment #811204 - Flags: review?(paul)
Attachment #811204 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/3b45275a1eff
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Comment on attachment 811204 [details] [diff] [review] Make App Manager disabled buttons look disabled (v2) [Approval Request Comment] Bug caused by (feature/regressing bug #): new feature (app manager) User impact if declined: UI polish Testing completed (on m-c, etc.): fx-team Risk to taking this patch (and alternatives if risky): very low String or IDL/UUID changes made by this patch: none
Attachment #811204 - Flags: approval-mozilla-aurora?
Priority: P2 → P1
Whiteboard: [waiting-for-aurora-approval]
Attachment #811204 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: verifyme
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:27.0) Gecko/20100101 Firefox/27.0 Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0 Mozilla/5.0 (X11; Linux i686; rv:27.0) Gecko/20100101 Firefox/27.0 Verified as fixed on Fx 26 beta 3 (20131107161719) and latest Aurora (20131108004000) using Firefox OS 1.2 or 1.3 Simulator.
status-firefox26: fixed → verified
status-firefox27: fixed → verified
QA Contact: petruta.rasa
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: