Closed
Bug 921222
Opened 11 years ago
Closed 11 years ago
Make disabled buttons look disabled
Categories
(DevTools Graveyard :: WebIDE, defect, P1)
DevTools Graveyard
WebIDE
Tracking
(firefox26 verified, firefox27 verified, b2g-v1.2 fixed)
VERIFIED
FIXED
Firefox 27
People
(Reporter: jryans, Assigned: jryans)
Details
Attachments
(1 file, 1 obsolete file)
|
2.65 KB,
patch
|
paul
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Currently it's not very clear that disabled buttons are disabled, since they don't change in appearance.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #810799 -
Flags: review?(poirot.alex)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 810799 [details] [diff] [review] Make App Manager disabled buttons look disabled Can you also do that for device.css? Don't use `cursor:not-allowed`. Use `pointer-events:none`.
Attachment #810799 -
Flags: review?(poirot.alex)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Made all changes from previous review.
Attachment #810799 -
Attachment is obsolete: true
Attachment #811204 -
Flags: review?(paul)
|
|
||
Updated•11 years ago
|
Attachment #811204 -
Flags: review?(paul) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/3b45275a1eff
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3b45275a1eff
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 811204 [details] [diff] [review] Make App Manager disabled buttons look disabled (v2) [Approval Request Comment] Bug caused by (feature/regressing bug #): new feature (app manager) User impact if declined: UI polish Testing completed (on m-c, etc.): fx-team Risk to taking this patch (and alternatives if risky): very low String or IDL/UUID changes made by this patch: none
Attachment #811204 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•11 years ago
|
Priority: P2 → P1
|
|
||
Updated•11 years ago
|
Whiteboard: [waiting-for-aurora-approval]
|
||
Updated•11 years ago
|
Attachment #811204 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/9b9076bdd9f5
status-b2g-v1.2:
--- → fixed
status-firefox26:
--- → fixed
status-firefox27:
--- → fixed
Whiteboard: [waiting-for-aurora-approval]
|
||
Comment 8•11 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:27.0) Gecko/20100101 Firefox/27.0 Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0 Mozilla/5.0 (X11; Linux i686; rv:27.0) Gecko/20100101 Firefox/27.0 Verified as fixed on Fx 26 beta 3 (20131107161719) and latest Aurora (20131108004000) using Firefox OS 1.2 or 1.3 Simulator.
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•