Closed
Bug 921226
Opened 8 years ago
Closed 8 years ago
Log on app install start and finish
Categories
(DevTools Graveyard :: WebIDE, defect, P2)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: jryans, Assigned: jryans)
Details
Attachments
(1 file, 1 obsolete file)
2.45 KB,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
Currently there's no indication that an app install is going on, and the process can take a while, leaving it unclear what is happening.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #810800 -
Flags: review?(poirot.alex)
Assignee | ||
Comment 2•8 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=17c4afe55613
Comment 3•8 years ago
|
||
Comment on attachment 810800 [details] [diff] [review] Log during app install in App Manager Review of attachment 810800 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/app-manager/content/projects.js @@ +231,5 @@ > } > + return installPromise.then(() => { > + this.connection.log("Install completed."); > + }, () => { > + this.connection.log("Install failed."); By doing that, you are eating the error, so that we no longer get the alert on error.
Attachment #810800 -
Flags: review?(poirot.alex)
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Alexandre Poirot (:ochameau) from comment #3) > By doing that, you are eating the error, so that we no longer get the alert > on error. Ah, good catch! :)
Attachment #810800 -
Attachment is obsolete: true
Attachment #813318 -
Flags: review?(poirot.alex)
Comment 5•8 years ago
|
||
Comment on attachment 813318 [details] [diff] [review] Log during app install in App Manager v2 Review of attachment 813318 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #813318 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=b1a07ae13471
Assignee | ||
Comment 7•8 years ago
|
||
Someone broke BC tests, trying again: https://tbpl.mozilla.org/?tree=Try&rev=4892daf969c1
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Updated•8 years ago
|
Whiteboard: [land-in-fx-team]
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/64479cdfb3a6
Keywords: checkin-needed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 9•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/64479cdfb3a6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Updated•3 years ago
|
Product: Firefox → DevTools
Updated•1 year ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•