921226 - Log on app install start and finish

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P2)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Currently there's no indication that an app install is going on, and the process can take a while, leaving it unclear what is happening.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Log during app install in App Manager

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=17c4afe55613

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 810800 [details] [diff] [review]
Log during app install in App Manager

Review of attachment 810800 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/app-manager/content/projects.js
@@ +231,5 @@
>      }
> +    return installPromise.then(() => {
> +      this.connection.log("Install completed.");
> +    }, () => {
> +      this.connection.log("Install failed.");

By doing that, you are eating the error, so that we no longer get the alert on error.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Log during app install in App Manager v2

(In reply to Alexandre Poirot (:ochameau) from comment #3)
> By doing that, you are eating the error, so that we no longer get the alert
> on error.

Ah, good catch! :)

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 813318 [details] [diff] [review]
Log during app install in App Manager v2

Review of attachment 813318 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=b1a07ae13471

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Someone broke BC tests, trying again: https://tbpl.mozilla.org/?tree=Try&rev=4892daf969c1

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/64479cdfb3a6

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/64479cdfb3a6