921310 - Don't collect extra data for restoring tabs

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: fix-restored-tab-collection

See bug 909048 comments 8 and 10.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 810913 [details] [diff] [review]
fix-restored-tab-collection

Review of attachment 810913 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/components/sessionstore/src/SessionStore.jsm
@@ +4338,5 @@
> +    // If the tab hasn't been restored yet, just return the data we
> +    // have saved for it.
> +    let browser = tab.linkedBrowser;
> +    if (!browser.currentURI || (browser.__SS_data && browser.__SS_tabStillLoading)) {
> +      let tabData = new TabData(this._collectBaseTabData(tab, {}));

this._collectBaseTabData(tab) should be sufficient. The 'options' argument has '{}' as its default value.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71784d4301dc

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/71784d4301dc