921343 - Findbar clears user selections when it auto-hides

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: After bug 666816

STEPS TO REPRODUCE:
1)  Load https://bugzilla.mozilla.org/show_bug.cgi?id=666816
2)  Type '/' and then type "abc" (which will not be found).
3)  Highlight some text in the page.
4)  Wait for the findbar to autohide.

ACTUAL RESULTS: The selection from step 3 is cleared.

EXPECTED RESULTS: Don't mess with selections you didn't create.

ADDITIONAL INFORMATION: close() calls finder.removeSelection() for some reason....  Why?

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Tom, starting with you on this one - please re-assign to another engineer if you can't take this on, but release tracking bugs need a person assigned.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

No need to track this for 26 given that we're tracking bug 916536.

Comment 3

[Tom S [:evilpie]]

Attachment: v1

https://tbpl.mozilla.org/?tree=Try&rev=6d89624e10ab waiting on try results before review. I hadn't run any tests locally, but I doubt there are any for this :(

Comment 4

[Tom S [:evilpie]]

Comment on attachment 816031 [details] [diff] [review]
v1

So green.

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 816031 [details] [diff] [review]
v1

Review of attachment 816031 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the 'long' turnaround time, I was having issues with my m-c build locally.

This is looking good to go.
About the way you solved this issue; can it be used as a general pattern to have it work for RemoteFinder with other focus-related issues? (English might be sloppy here... very tired)

Comment 6

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95b04871f4ae

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/95b04871f4ae

Comment 8

[Ioana (away)]

Verified as fixed with Firefox 27 beta 4 on Windows 7 x64bit, Mac OS X 10.9, Ubuntu 13.04 32bit.