921392 - [LockScreen] Need to dark the icons of locksceen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

It's still too light that there're no obvious difference between the idle mode and the activated mode.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

65% should be okay, and 50% is too dark.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

I'll also fix the problem that the icons would be dark again after user start to pull the handle.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Icons ; dark 65%

Finished the bug but need information from UX Patryk's opinion.
The video shows the contrast between the dark and light icons.

Comment 4

[Patryk Adamczyk [:patryk] UX]

Looks good to me, video is not ideal to make final decisions on, ideally I'd see in real life, but I think we're probably 95% there. So lets ship this for v.1.2, if anything we can make some minor adjustments for v.1.3.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Minor CSS & JS adjustments.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/529a4d741df4867eaa2adf0aaeef0fb5015752b3

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

a=timdream and remove koi?

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Please uplift, thanks!

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 529a4d741df4867eaa2adf0aaeef0fb5015752b3
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

The problem that unable to uplift it to v1.2 now has a possible solution I commented in the Bug 921334 and had already needinfo John Ford to make sure it's workable.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 529a4d741df4867eaa2adf0aaeef0fb5015752b3 to:
v1.2: 13c77362cfa7c137fe981de75836f52dd3e8c062

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 529a4d741df4867eaa2adf0aaeef0fb5015752b3 to:
v1.3 already had this commit