921421 - [Video] pause the video and back to beginning when a video plays to end

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

When playing a very short video, like 2sec, we don't have ht opportunity to see detail info, delete, or share the video in the player view. The current behavior is to go back to list view when it plays to end.

As per rob's comment, we discussed offline, he thought we should pause the video and go back to the beginning of video when the video plays to end.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: pause the video and moves to the begins

When video plays to end, the player pauses the video playing and moves the beginning of this video.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: bug921421.zip

Hi Rob,

Please also review this one. I followed your design to pause the video and move the video to the beginning when it plays to end.

Comment 3

[David Flanagan [:djf]]

Comment on attachment 811807 [details]
pause the video and moves to the begins

The change you made looks fine.

In the process of checking that hidePlayer() is still called correctly to update the metadata, however, I discovered a related bug that we should fix, either here, or in a new bug.

hidePlayer() takes a boolean argument named updateMetadata, but also has a nested function named updateMetadata.  This means that when you call hidePlayer() with the argument false, that argument is being ignored.  That should be an easy bug to fix.

Also note another implication of this change. By pausing the video and not returning to the list of thumbnails, video metadata parsing does not automaticaly resume.  If new videos are being scanned, the user will have to manually return to the thumbnail list before more thumbanails are added to the list.  If this is a problem, then a deeper refactoring will be required here.

Comment 4

[David Flanagan [:djf]]

John,

Note that the travis build failed on your patch. It appears unrelated, but it could be that other problems prevented tests from running. If there are any video app tests that rely on the behavior you are changing here, don't forget to update them, too.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

I rename the "updateMetadata" argument as updateVideoMetadata to prevent the conflict between them.

I also found the travis failed. That's not related to video app. Thanks for this.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/5f2d9831cc8f8906e0020bc7040c073a4f58ad30

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Nominate it as 1.3? because bug 903920 depends on this one.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

bug 903920 is no more 1.3+, clear the 1.3? flag.