921456 - Remove unused nsSVGElement::GetPresentationAttribute prototype.

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

getPresentationAttribute has been removed from SVG 2 anyway.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Remove unused nsSVGElement::GetPresentationAttribute prototype.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Maybe also remove the comments from dom/webidl/SVGElement.webidl and dom/interfaces/svg/nsIDOMSVGElement.idl, then?

Comment 3

[Cameron McCormack (:heycam)]

Oops, I did a "git grep GetPresentationAttribute" and didn't see any results, so figured they must have already been left out of the IDL.  I needed to do "git grep getPresentationAttribute", of course...

Comment 4

[Cameron McCormack (:heycam)]

Attachment: Remove unused nsSVGElement::GetPresentationAttribute prototype. (v1.1)

Comment 5

[Robert Longson [:longsonr]]

Comment on attachment 811098 [details] [diff] [review]
Remove unused nsSVGElement::GetPresentationAttribute prototype. (v1.1)

On the whole I'd prefer the comment in SVGElement.webidl to be left alone as it acts as a warning to anyone thinking of implementing this.

Comment 6

[Robert Longson [:longsonr]]

If you want to remove the commented out xmlbase, xmllang and xmlspace from SVGElement.webidl in this or any other bug you can have an r+ for that too.

Comment 7

[Cameron McCormack (:heycam)]

(In reply to Robert Longson from comment #5)
> Comment on attachment 811098 [details] [diff] [review]
> Remove unused nsSVGElement::GetPresentationAttribute prototype. (v1.1)
> 
> On the whole I'd prefer the comment in SVGElement.webidl to be left alone as
> it acts as a warning to anyone thinking of implementing this.

We don't have a commented out SVGAnimateColorElement.webidl file to ward people off implementing that. :)  (As another example of something that was in SVG 1.1 but not in 2.)

I'll think about removing the comments for xmlbase etc. once I get around to bringing it back up in the WG for removal.

Comment 8

[Robert Longson [:longsonr]]

OK, remove it then.

Comment 9

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6844baec2125

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6844baec2125