Closed
Bug 921456
Opened 11 years ago
Closed 11 years ago
Remove unused nsSVGElement::GetPresentationAttribute prototype.
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: heycam, Assigned: heycam)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
2.67 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
getPresentationAttribute has been removed from SVG 2 anyway.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #811096 -
Flags: review?(longsonr)
|
||
Comment 2•11 years ago
|
||
Maybe also remove the comments from dom/webidl/SVGElement.webidl and dom/interfaces/svg/nsIDOMSVGElement.idl, then?
|
|
Assignee | |
Comment 3•11 years ago
|
||
Oops, I did a "git grep GetPresentationAttribute" and didn't see any results, so figured they must have already been left out of the IDL. I needed to do "git grep getPresentationAttribute", of course...
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #811098 -
Flags: review?(longsonr)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #811096 -
Attachment is obsolete: true
Attachment #811096 -
Flags: review?(longsonr)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 811098 [details] [diff] [review]
Remove unused nsSVGElement::GetPresentationAttribute prototype. (v1.1)
On the whole I'd prefer the comment in SVGElement.webidl to be left alone as it acts as a warning to anyone thinking of implementing this.
Attachment #811098 -
Flags: review?(longsonr) → review+
|
|
||
Comment 6•11 years ago
|
||
If you want to remove the commented out xmlbase, xmllang and xmlspace from SVGElement.webidl in this or any other bug you can have an r+ for that too.
|
|
Assignee | |
Comment 7•11 years ago
|
||
(In reply to Robert Longson from comment #5)
> Comment on attachment 811098 [details] [diff] [review]
> Remove unused nsSVGElement::GetPresentationAttribute prototype. (v1.1)
>
> On the whole I'd prefer the comment in SVGElement.webidl to be left alone as
> it acts as a warning to anyone thinking of implementing this.
We don't have a commented out SVGAnimateColorElement.webidl file to ward people off implementing that. :) (As another example of something that was in SVG 1.1 but not in 2.)
I'll think about removing the comments for xmlbase etc. once I get around to bringing it back up in the WG for removal.
|
|
||
Comment 8•11 years ago
|
||
OK, remove it then.
|
|
Assignee | |
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•