Certificate usage on Firefox Android 24 and newer

VERIFIED FIXED in Firefox 25

Status

()

Firefox for Android
General
VERIFIED FIXED
4 years ago
10 months ago

People

(Reporter: info, Assigned: kats)

Tracking

({regression})

24 Branch
Firefox 27
ARM
Android
regression
Points:
---

Firefox Tracking Flags

(firefox24 wontfix, firefox25 verified, firefox26 verified, firefox27 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130618035212

Steps to reproduce:

On Firefox 23 i use add-on for import Certificates
Cc["@mozilla.org/security/x509certdb;1"].getService(Ci.nsIX509CertDB2)
&& for user certificate
Cc["@mozilla.org/security/x509certdb;1"].getService(Ci.nsIX509CertDB);

This add-in works with Firefox 23 and newer(Test with Aurora 26 && Fennec 27)
(Imports OK)





Actual results:

With firefox 23, when i load secure URL,  i select my user certificate (from the firefox Keystore) and i 'm connect with success

With firefox 24 and newer, i doesn't show prompt dialog for select user certificate and result is =ssl_error_handshake_failure_alert

Log (with Aurora >>> same bug with firefox 24 and fennec 27.)

09-27 15:48:17.253: E/GeckoConsole(22691): [JavaScript Error: "this.getPrompt(...).addLabel(...).addMenuList is not a function" {file: "jar:jar:file:///data/app/org.mozilla.fennec_aurora-1.apk!/assets/omni.ja!/components/NSSDialogService.js" line: 188}]
09-27 15:48:17.388: E/GeckoConsole(22691): An error occurred during a connection to secret.server.com.
09-27 15:48:17.388: E/GeckoConsole(22691): SSL peer was unable to negotiate an acceptable set of security parameters.
09-27 15:48:17.388: E/GeckoConsole(22691): (Error code: ssl_error_handshake_failure_alert)
(Reporter)

Updated

4 years ago
Severity: normal → blocker
OS: Windows 7 → Android
Priority: -- → P1
Hardware: x86 → ARM
Please don't set severity.
Severity: blocker → normal
Priority: P1 → --
(Reporter)

Comment 2

4 years ago
(In reply to Aaron Train [:aaronmt] from comment #1)
> Please don't set severity.

Ok ;(
It's a  regression ?
Can you paste how you're calling the prompt dialog? I think this is due to changes on mozilla-24 from bug 878848. I've CC'ed Wes and Kats as they touched NSSDialogService.js
Keywords: regression
This is just a typo (and I this code is hard to test). The method should be addMenulist()
If you can confirm that info@cc2i.org, we can close this out as invalid.
Flags: needinfo?(info)
(In reply to Aaron Train [:aaronmt] from comment #5)
> If you can confirm that info@cc2i.org, we can close this out as invalid.

The bug is in our code; at http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/NSSDialogService.js#185
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(info)
Fixed with wesj's rubberstamp r+ on IRC:

https://hg.mozilla.org/integration/fx-team/rev/d39711d1bc60
Created attachment 811260 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 878848
User impact if declined: adding certificates (via addons) might fail
Testing completed (on m-c, etc.): none, but hopefully the reporter will verify on the nightly build that has the fix
Risk to taking this patch (and alternatives if risky): low risk, typo fix
String or IDL/UUID changes made by this patch: none
Assignee: nobody → bugmail.mozilla
Attachment #811260 - Flags: review+
Attachment #811260 - Flags: approval-mozilla-beta?
Attachment #811260 - Flags: approval-mozilla-aurora?
Blocks: 878848
status-firefox24: --- → affected
status-firefox25: --- → affected
status-firefox26: --- → affected
status-firefox27: --- → fixed
https://hg.mozilla.org/mozilla-central/rev/d39711d1bc60
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
(Reporter)

Comment 10

4 years ago
Thank you all for the response!
(Reporter)

Comment 11

4 years ago
I tested it at the next nithly build.

Updated

4 years ago
Status: RESOLVED → VERIFIED

Updated

4 years ago
Attachment #811260 - Flags: approval-mozilla-beta?
Attachment #811260 - Flags: approval-mozilla-beta+
Attachment #811260 - Flags: approval-mozilla-aurora?
Attachment #811260 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/e0353f4ef662
https://hg.mozilla.org/releases/mozilla-beta/rev/24a45f7dd8f0
status-firefox24: affected → wontfix
status-firefox25: affected → fixed
status-firefox26: affected → fixed
(Reporter)

Comment 13

4 years ago
Nice !
I post a addon for importing User Certificate (Firefox Android) :

https://addons.mozilla.org/en-US/firefox/addon/addcertificate/

Thank you !!

Updated

4 years ago
status-firefox25: fixed → verified
status-firefox26: fixed → verified
status-firefox27: fixed → verified
You need to log in before you can comment on or make changes to this bug.