921496 - Convert [NavigatorProperty] extended attributes to plain navigator properties

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Masatoshi Kimura [:emk]]

It will just bring confusion since bug 838146 fixed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

The goal here was to be able to add new things to navigator without writing C++ code.

At one point there was discussion about doing this via code-generating a base class for Navigator that would implement getters for the various navigator-property stuff...

Comment 2

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 3

[Boris Zbarsky [:bzbarsky]]

OK, I think we should go ahead and do this. There's precisely one consumer of NavigatorProperty, and it would be pretty simple to just switch it to a normal property (like Window's .external) and remove the complexity... We could add a helper C++ method to make it a little simpler and less codepasty to implement things like this.

Thoughts?

Comment 4

[Boris Zbarsky [:bzbarsky]]

We could add a helper C++ method to make it a little simpler and less codepasty to implement things like this.

Filed bug 1570350 on that.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 921496 part 1. Remove the one consumer of NavigatorProperty. r=peterv

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 921496 part 2. Remove NavigatorProperty. r=peterv

Comment 7

[Andrew McCreight [:mccr8]]

I haven't looked at this before, but it certainly looks like a ton of code for something that only has a single consumer. The code for the consumer doesn't look particular involved, either.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca578c57a4f0
part 1.  Remove the one consumer of NavigatorProperty.  r=peterv
https://hg.mozilla.org/integration/autoland/rev/cc8b5dcacc85
part 2.  Remove NavigatorProperty.  r=peterv

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ca578c57a4f0
https://hg.mozilla.org/mozilla-central/rev/cc8b5dcacc85