Open Bug 921585 Opened 11 years ago Updated 1 year ago

PK11_CipherOp should use the unsigned int type for the buffer size parameters

Categories

(NSS :: Libraries, enhancement, P5)

enhancement

Tracking

(Not tracked)

People

(Reporter: wtc, Unassigned)

Details

PK11_CipherOp uses the signed int type for the buffer size parameters. This is different from the NSS convention of using the unsigned int type for buffer size. We should be able to change PK11_CipherOp without breaking binary compatibility. As for source compatibility, this change may cause a compiler warning, perhaps even a compilation error in C++.
vfy_VerifyData, VFY_VerifyDataDirect, VFY_VerifyData, and VFY_VerifyDataWithAlgorithmID have the same problem. This consequently affects CERT_VerifySignedDataWithPublicKey and the similar functions.
Severity: minor → S4
Type: defect → enhancement
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.